i#5912: Add caching and clean up PC discontinuity checks #5965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 89b342a.
lihasgupta
changed the title
derekbruening
approved these changes
Sep 22, 2023
lihasgupta
changed the title
lihasgupta
deleted the
i5912-incorrect-invariant-pc-discontinuity-kernel-xfer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes redundant
pre_signal_flow_continuitycheck in the invariant_checker.Adds unit tests to check for PC discontinuities in the transitions between instructions and kernel xfer markers
Adds caching around the decoding, to prevent repeated calls to the expensive
decode_from_copy()function.Refactors the invariant_checker to use
instr_info_tstructs which group together memref's and their corresponding decodings.Fixes: #5912
Fixes: #6006