i#5975: Add invariant check that read/write records match operands #6283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cords matching operands. Add an invariant check to verify the number of memory read/write records is matching the operands. Mark x86 "rep" operands as predicated, and skip the check since the number of records depends on run time register values. Change check_sane_control_flow() to use gen_instr_encoded() when encoding is expeced. Fixes #5975
…cords matching operands. Add an invariant check to verify the number of memory read/write records is matching the operands. Mark x86 "rep" operands as predicated, and skip the check since the number of records depends on run time register values. Change check_sane_control_flow() to use gen_instr_encoded() when encoding is expeced. Fixes #5975
ivankyluk
changed the title
derekbruening
approved these changes
Sep 7, 2023
ivankyluk
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an invariant check to verify the number of memory read/write records is matching the operands.
Update check_sane_control_flow() to use instrlist_t and memref_with_IR_t to avoid hardcoded encodings. Current tests fail the new check since they have memory accesses.
Fixes #5975