i#5694 core-sharded: Add get_shard_index() + get_tid() #6568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds 2 new memtrace_stream_t interfaces to simplify generalizing tools to handle either thread or core sharded operation: + get_shard_index() returns a 0-based shard ordinal regardless of whether core-sharded or thread-sharded. + get_input_tid() returns the thread id of the current input. This is a convenience method for use in parallel_shard_init_stream() prior to access to any memref_t records. Changes an existing interface: + Guarantees that the shard_index passed to parallel_shard_init_stream() is a 0-based ordinal. Implements the 2 new interfaces in the scheduler and adds two new interface there: + get_output_stream_ordinal() to get the underlying output when using single_lockstep_output. + get_output_cpuid(ord) taking in an ordinal so the analyzer or other user can get the cpuids statically when using single_lockstep_output. Removes dr$sim's manual mapping of cpuid to core index in favor of using the new get_shard_index(). Updates all the analysis tools to use the new interfaces and to generalize their code to either handle both thread and core shards (reuse_time, reuse_distance, basic_counts, histogram, opcode_mix, syscall_mix, record_filter) or explicitly return an error for core-sharded modes (func_view, invariant_checker). (schedule_stats and record_filter needed no changes.) Adds some sanity tests on the new interfaces. Adds a new end-to-end test running the newly-updated tools as -core_sharded. Issue: #5694
where the scheduler remembers and returns the last memref.data.tid for get_shard_index(). Expand mock stream for unit tests. Skip invariant stream checks for mock stream.
…up test templates
abhinav92003
approved these changes
Jan 23, 2024
derekbruening
changed the title
+ s/get_input_tid/get_tid/ + is_combined_stream helper + is_a_unit_test helper + use sentinels + update comments
+ s/set_input_tid/set_tid/ + Have it set the shard index to the dynamic-discovery-order tid ordinal to make it easier on tests Revert the sentinel for last_thread_ back to -1 to support many tests setting memref tids to 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 new memtrace_stream_t interfaces to simplify generalizing tools to handle either thread or core sharded operation:
For online analysis where there's a single input, the scheduler remembers and returns the last memref.data.tid for get_tid() and uses the dynamic tid discovery order for get_shard_index().
Changes an existing interface:
Implements the 2 new interfaces in the scheduler and adds two new interface there:
Removes dr$sim's manual mapping of cpuid to core index in favor of using the new get_shard_index().
Updates all the analysis tools to use the new interfaces and to generalize their code to either handle both thread and core shards (reuse_time, reuse_distance, basic_counts, histogram, opcode_mix, syscall_mix, record_filter) or explicitly return an error for core-sharded modes (func_view, invariant_checker). (schedule_stats and record_filter needed no changes.)
Updates several unit tests to handle these changes:
Adds some sanity tests on the new interfaces.
Adds a new end-to-end test running the newly-updated tools as -core_sharded. Limits the reuse_time histogram printing output to avoid hanging CMake's regex matcher in this test.
Issue: #5694