-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i#6662 public traces, part 6: invariant_checker #6861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using -filter_keep_func_ids.
edeiana
commented
Jul 1, 2024
edeiana
commented
Jul 1, 2024
edeiana
commented
Jul 1, 2024
edeiana
commented
Jul 1, 2024
derekbruening
approved these changes
Jul 2, 2024
clients/drcachesim/tests/invariant_checker_on_regdeps_trace.templatex
Outdated
Show resolved
Hide resolved
clients/drcachesim/tests/invariant_checker_on_regdeps_trace.templatex
Outdated
Show resolved
Hide resolved
Missing: change ci_shared_app to xfer_kernel_app, move WARNING at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OFFLINE_FILE_TYPE_ARCH_REGDEPS traces lack some markers and have instructions with DR_ISA_REGDEPS encodings, which don't have all the necessary information to perform all the invariant checks.
Here we disable or modify some checks for invariant errors to handle OFFLINE_FILE_TYPE_ARCH_REGDEPS synthetic traces in the invariant_checker tool.
Specifically, we disable:
We modify the check for matching loads/stores performed by a DR_ISA_REGDEPS fetched instruction with the subsequent read/write records, by requiring that if a DR_ISA_REGDEPS instruction performs a load/store (we use the instruction category to determine that), at least one subsequent read/write record must be present.
Issue #6662