i#6662 public traces, part 9: TLB simulator with v2p #6961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of a simple reader for virtual to
physical address mapping in textproto format.
The reader parses blocks in the following form:
address_mapping {
virtual_address: 0x123
physical_address: 0x3
}
present in the provided textproto file to create a
map in memory from virtual to physical address.
Adds unit tests and a sample v2p textproto file
to check the correctness of the generated map.
Issue #6662
… i6662-v2p-tlb-simulator
These info, along with v2p_map, is now grouped together in v2p_info_t.
… i6662-v2p-tlb-simulator
… i6662-v2p-tlb-simulator
… i6662-v2p-tlb-simulator
… i6662-v2p-tlb-simulator
We want to provide a virtual to physical mapping for the release of public traces to be used with our TLB simulator. We enable the TLB simulator to operate on the physical addresses provided by a v2p.textproto file, which is read by the previously added v2p_reader. Issue #6662
Renamed v2p textproto file (it's not just a map, it also contains page size, count and bytes mapped).
… i6662-v2p-tlb-simulator
```
CMake Error at /opt/actions-runner/_work/dynamorio/dynamorio/suite/runsuite.cmake:304 (message):
ERROR: diff contains tabs:
+address_mapping_group {
```
…d physical addresses.
edeiana
commented
Sep 15, 2024
|
Requesting re-review to double check my logic on page_size and the newly added unit test. Right now we have 3 possible page sizes:
If we are in case 3. that page size overwrites 1. and 2.. Should we have a warning or an error if for 2. the user sets a different page size while still wanting to use v2p.textproto? |
Improved this option description in -help, clarifying that -use_physical must be used in order for v2p.textproto to be used.
derekbruening
approved these changes
Sep 16, 2024
Addressed minor PR feedback.
… the trace/ dirs (trace/ is created when running the TLB simulator).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to provide a virtual to physical mapping for
the release of public traces to be used with our TLB
simulator.
We enable the TLB simulator to operate on the physical
addresses provided by a v2p.textproto file, which is
read by the previously added v2p_reader.
Adds an end-to-end test "tool.drcacheoff.tlb_simulator_v2p"
and a v2p.textproto mapping to
clients/drcachesim/tests/drmemtrace.threadsig.aarch64.raw.
Adds unit tests to check that the addresses used by the TLB
simulator are the actual physical ones.
Issue #6662