Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#6662 public traces: allow v2p.textproto in trace dir #7136

Merged
merged 4 commits into from
Jan 1, 2025

Conversation

edeiana
Copy link
Contributor

@edeiana edeiana commented Dec 15, 2024

Allows the v2p.textproto file to be in the trace directory of public traces
to avoid the following error:

$ drrun -t drmemtrace -indir ${path_to_public_trace_dir} -tool invariant_checker
Invalid header
Failed to initialize scheduler: Failed to open ${path_public_trace_dir}/v2p.textproto
ERROR: failed to initialize analyzer

Issue #6662

Allows the v2p.textproto file to be in the trace directory
of public traces to avoid the following error:
```
$ drrun -t drmemtrace -indir ${path_to_public_trace_dir} -tool invariant_checker
Invalid header
Failed to initialize scheduler: Failed to open <OMITTED>/v2p.textproto
ERROR: failed to initialize analyzer
```

Issue #6662
@edeiana edeiana requested a review from abhinav92003 December 15, 2024 08:39
@edeiana edeiana requested a review from abhinav92003 December 15, 2024 23:53
@edeiana edeiana merged commit 7203e72 into master Jan 1, 2025
17 checks passed
@edeiana edeiana deleted the i6662-v2p-file branch January 1, 2025 00:10
edeiana added a commit that referenced this pull request Jan 7, 2025
Update the version number to 11.3.
Necessary for compatibility with the new public traces
and their v2p.textproto file (xref: #7136 #7174).

Issue #6662
@edeiana edeiana mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants