Fix #update, #update!, .update_fields, .upsert and save empty Set and String as nil #626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a limitation of DynamoDB - a Set cannot be empty (documentation). An attempt to save such incorrect value leads to a validation error. So in Dynamoid at saving an empty Set is replaced with
nil
to prevent raising exception.Here we fix some missing cases when empty Set is not replaced with
nil
.There was a yet another DynamoDB limitation - we couldn't save empty String. This is not actual anymore but Dynamoid still replaces empty Strings with
nil
as well. It should be changed in some future release.Fixed methods:
#update
,#update!
.update_fields
.upsert