Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger error on CI #866

Merged
merged 3 commits into from
Feb 15, 2025

Conversation

andrykonchin
Copy link
Member

@andrykonchin andrykonchin commented Feb 14, 2025

Explicit requiring the logger library is needed for Rails 6.0-7.0. The issue is already fixed in Rails 7.1 and above.

See the following for details:

Example of the exception:

NameError:
  uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger

      Logger::Severity.constants.each do |severity|
      ^^^^^^
# ./vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:12:in `<module:LoggerThreadSafeLevel>'
# ./vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:9:in `<module:ActiveSupport>'
# ./vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:8:in `<top (required)>'
# ./vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.8.7/lib/active_support/logger_silence.rb:5:in `require'
# ./vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.8.7/lib/active_support/logger_silence.rb:5:in `<top (required)>'
# ./vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.8.7/lib/active_support/logger.rb:3:in `require'
# ./vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.8.7/lib/active_support/logger.rb:3:in `<top (required)>'
# ./vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.8.7/lib/active_support.rb:29:in `require'
# ./vendor/bundle/ruby/3.1.0/gems/activesupport-7.0.8.7/lib/active_support.rb:29:in `<top (required)>'
# ./spec/spec_helper.rb:8:in `require'
# ./spec/spec_helper.rb:8:in `<top (required)>'
# ./spec/dynamoid/validations_spec.rb:3:in `require'
# ./spec/dynamoid/validations_spec.rb:3:in `<top (required)>'
No examples found.

Copy link

Code Coverage

Package Line Rate Health
dynamoid 92%
Summary 92% (3426 / 3739)

Minimum allowed line rate is 90%

@andrykonchin andrykonchin merged commit 41f015a into master Feb 15, 2025
70 checks passed
@andrykonchin andrykonchin deleted the ak/fix-uninitialized-constant-logger-issue-on-ci branch February 15, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant