Skip to content

Conversation

Felix-Dynamsoft
Copy link
Contributor

@Felix-Dynamsoft Felix-Dynamsoft commented Jun 18, 2024

Problem

React README wasn't accurate, and also didn't have a guide to setup and launch the sample we currently have.
In the README, the sample code is not the same as what we have in the sample.
We also haven't formatted the code.

Solution

  1. Added version of dynamsoft barcode reader, and also added a quickstart.
  2. Ensured Sample Code is very similar to the README. with only styling difference.
  3. Formatted the code with Prettier - Code formatter

Big changes to note:
GENERAL

  1. Used Prettier Code Formatter
  2. Ensured README.md and the code is the same, with only HelloWorld.tsx having different styles.

README.md

  1. Added version of DBR Bundle on description
  2. Added Quick start section so users can run the example program
  3. Added purpose and goal to creating the sample project
  4. Changed al the installs to just install dynamsoft-barcode-reader-bundle
  5. changed cvr to dynamsoft.config.ts

VideoCapture.tsx / ImageCapture.tsx

  1. Removed unused EnumapturedResultItemType import
  2. changed uiContainer to cameraViewContainer
  3. Changed how we append the results to match docs resultsContainer.current!.textContent += ${item.formatString}: ${item.text}\n\n;
  4. Removed filter.setDuplicateForgetTime
  5. Updated note on The component should never update for react-hook
  6. Changed classes to remove Hungarian Notation

@Felix-Dynamsoft Felix-Dynamsoft changed the title feat: updated react sample to follow readme feat: updated react sample to follow README.md Jun 18, 2024
@Felix-Dynamsoft Felix-Dynamsoft changed the title feat: updated react sample to follow README.md feat: updated react and react-hooks sample and docs Jun 25, 2024
npm install dynamsoft-barcode-reader
npm install dynamsoft-capture-vision-router
npm install dynamsoft-camera-enhancer
npm install dynamsoft-barcode-reader-bundle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm install dynamsoft-barcode-reader-bundle@10.2.1000 -E

@Keillion Keillion merged commit 90d38e9 into main Jun 26, 2024
@Felix-Dynamsoft Felix-Dynamsoft deleted the update-react branch July 18, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants