Skip to content

Commit

Permalink
Merge branch 'jgfouca/scripts/create_test_arg_check_fix' into next (PR
Browse files Browse the repository at this point in the history
…#320)

create_test: Fix arg checking

Bug introduced due to changed in default values of options. Bug
occurred if user did not do either baseline generation or comparison.

[BFB]

* jgfouca/scripts/create_test_arg_check_fix:
  create_test: Fix arg checking
  • Loading branch information
jgfouca committed Sep 3, 2015
2 parents a34d9c1 + e6e6387 commit cd11207
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/acme/create_test
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ formatter_class=argparse.ArgumentDefaultsHelpFormatter

expect(not (args.generate and args.compare),
"Cannot generate and compare baselines at the same time")
expect(not (args.baseline_name is not None and (not args.compare and not args.generate)),
expect(not (args.baseline_name != default_baseline_name and (not args.compare and not args.generate)),
"Provided baseline name but did not specify compare or generate")

if (args.no_build):
Expand Down

0 comments on commit cd11207

Please sign in to comment.