Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative ci in photosynthesis calculation. #1233

Closed
jinyuntang opened this issue Jan 23, 2017 · 8 comments · Fixed by #1272
Closed

Negative ci in photosynthesis calculation. #1233

jinyuntang opened this issue Jan 23, 2017 · 8 comments · Fixed by #1272
Assignees
@jinyuntang
Labels
bug Land

Comments

@jinyuntang
Copy link
Contributor

The coupling between stomata conductance and photosynthesis occasionally resulted in negative intracellular CO2 concentrations in the current numerical solver. This in the short-term requires a fix for situations when the gs-An formulation does not have a solution.
@rljacob rljacob added the Land label Jan 26, 2017
@bishtgautam
Copy link
Contributor

This is a "physics" related bug for which @jinyuntang is coming up with a solution. So, I'm assigning him to fix it.

@bishtgautam bishtgautam assigned jinyuntang and unassigned bishtgautam Feb 2, 2017
@bishtgautam bishtgautam changed the title negative ci in photosynthesis calculation. Negative ci in photosynthesis calculation. Feb 3, 2017
@jinyuntang
Copy link
Contributor Author

@bishtgautam, I followed your instructions at https://gist.github.com/bishtgautam/2c729d49fec70010a50b582c4f71f97d and did the acme_land_developer test, all seemed fine. What's the next step?

@bishtgautam
Copy link
Contributor

You can issue a PR with the fix.

@jinyuntang
Copy link
Contributor Author

@bishtgautam Good! I will do it shortly.

@jinyuntang jinyuntang mentioned this issue Feb 16, 2017
Merged
@bishtgautam bishtgautam reopened this Apr 19, 2017
bishtgautam pushed a commit that referenced this issue Apr 24, 2017
Merge branch 'jinyuntang/lnd/cifix' into next
73533bc 
The current PhotosynthesisMod returns negative ci (intracellular CO2) in exiting
the photosynthesis solver, because the mathematical formulation of photosynthesis
and stomata conductance does not guarantee a solution. This fix ensures that ci
is always positive by forcing the solver to converge in cases when no solution is available.

[Non BFB] not- Bit-For-Bit
Fixes #1233
bishtgautam pushed a commit that referenced this issue Apr 25, 2017
Merge branch 'jinyuntang/lnd/cifix' (PR #1272)
381b199 
The current PhotosynthesisMod returns negative ci (intracellular CO2) in exiting
the photosynthesis solver, because the mathematical formulation of photosynthesis
and stomata conductance does not guarantee a solution. This fix ensures that ci
is always positive by forcing the solver to converge in cases when no solution is available.

[Non BFB] not- Bit-For-Bit
Fixes #1233
@bishtgautam bishtgautam reopened this Apr 27, 2017
@rljacob rljacob added the bug label Apr 27, 2017
@rljacob rljacob reopened this May 10, 2021
@rljacob
Copy link
Member

rljacob commented May 10, 2021

@bishtgautam is this still an active bug? Not sure why PR #1272 didn't fix it.

@bishtgautam
Copy link
Contributor

#1272 was merged to next and then reverted as it resulted in unexpected results. The CIME update closed the issue as Github or Git misinterpreted the same issue number in e3sm and cime repo.

@rljacob
Copy link
Member

rljacob commented May 10, 2021 •
edited
Loading

Ok I see the rest of the conversation now. Looks like it was merged all the way to master and then reverted. There doesn't seem to be a way to remove the "Merged" status from that PR.

@bishtgautam
Copy link
Contributor

We can close this issue as negative ci has not been reported in any of the multiple simulations the team has run since 2017.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinyuntang jinyuntang

Labels
bug Land
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix negative leaf intracellular CO2 computed in PhotosynthesisMod E3SM-Project/E3SM
3 participants
@rljacob @bishtgautam @jinyuntang