Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_newcase is copying over more Depends files to the case directory than expected #1239

Closed
worleyph opened this issue Jan 25, 2017 · 0 comments · Fixed by #1321
Closed
Assignees

Comments

@worleyph
Copy link
Contributor

In CIME2, the create_newcase script logic was as follows:

 # Copy Depends files if they exist 
 if( -e "$machdir/Depends.$mach.$compiler" ) {
     $sysmod = "cp $machdir/Depends.$mach.$compiler $caseroot/";
     system($sysmod) == 0 or die "ERROR: $sysmod failed: $?\n";
 }else{
 if( -e "$machdir/Depends.$mach" ) {
     $sysmod = "cp $machdir/Depends.$mach $caseroot/";
     system($sysmod) == 0 or die "ERROR: $sysmod failed: $?\n";
 }
 if( -e "$machdir/Depends.$compiler" ) {
     $sysmod = "cp $machdir/Depends.$compiler $caseroot/";
     system($sysmod) == 0 or die "ERROR: $sysmod failed: $?\n";
 }
 }

and either a Depends.$mach.$compiler file was copied into the case directory OR (exclusive)
a Depends.$mach or (inclusive) a Depends.$compiler file was copied.

In CIME5 we are getting both Depends.$mach.$compiler and Depends.$compiler, for example.

This is a change in behavior. If not deliberate, then it is a bug. POCs for systems have been maintaining only Depends.$mach.$compiler to my understanding, at least on Titan.

@worleyph worleyph changed the title create_newcase is copying over more than one Depends file to the case directory create_newcase is copying over more Depends files to the case directory than expected Jan 25, 2017
worleyph pushed a commit that referenced this issue Mar 26, 2017
Restore Titan support after CIME5.2 merge. A number of issues prevented successful create, set-up, build and run phases on Titan after the merge of CIME5.2. Even with these resolved, some functionality was lost, e.g. support for using a different number of MPI tasks per node for nonoverlapping components and support for more than one compiler. Finally, support for netcdf4 files was missing when using PGI.

    Remove CESM_REPO.
    Add better support for netcdf and pnetcdf in config*.xml .
    Use findNetcdf.cmake from pio2 in pio1.
    Use newer cmake, required by pio2.
    Fix aprun command construction.
    Fix Macro maker, to enable multiple compiler support.
    Update modules and paths to enable netcdf4 support and multiple compiler support.

Fixes #1327
Fixes #1330
Fixes #1344

Also, (already fixed, but verified here)

Fixes #1239

Testing has focused on production-like cases, including low resolution water cycle and high resolution GMPAS, both with and without the v3 MPAS meshes and with a number of different PE layouts. acme_developer is not yet working, for reasons distinct from the pull request, and without these changes, progress will not be possible on getting the acme_developer to work again.

A unit test was added for the updated aprun command construction capability, and this was passed.

[BFB]
agsalin pushed a commit that referenced this issue Apr 13, 2017
need to set RTM to NULL in both cases in order to have this work with…
Fix needed for upcoming pythonization of rtm and mosart buildnml

RTM is being used incorrectly in the ssp test - and this fix ensures that both phases of NULL.
This enables the new RTM and MOSART pythonized buildnml scripts to pass the SSP test.

Only ran the ran SSP_Ld10.f19_g16.I1850CLM45BGC.yellowstone_pgi.clm-default test. Verified that the test passed and the only differences with respect to the baseline were the RTM fields.

Test suite: None
Test baseline:
Test namelist changes:
Test status: bit for bit - except for any test using ssp.py

Fixes

User interface changes?: None

Code review:jedwards
jgfouca pushed a commit that referenced this issue Jan 8, 2018
0f241db response to comments
1007a7a cannot predetermin ndims here
99ef07d Merge pull request #1241 from NCAR/free_new_allocs
29ed162 free recently allocated vars
fbc3584 Merge pull request #1239 from NCAR/dontuse_nc_max
63dee3d Merge pull request #1240 from NCAR/limitto2GiB
64f2492 limit to 2GiB due to romio bug
29aee05 dont use NC_MAX values
d831ad3 Merge pull request #1231 from mgduda/mpi_type_fix
e996bdb Merge pull request #1222 from NCAR/ejh_autoconf_logging
426af22 Partial fix for incorrect type of 'mpi_type' in pioc_support.c
7eb724f added enable-logging option to autotools build

git-subtree-dir: src/externals/pio2
git-subtree-split: 0f241db88cfee1912a2769a052dba0d2d79f83d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants