Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./case.build --clean <COMPONENT_NAME> does not remove Srcfiles and Depends #1474

Closed
jayeshkrishna opened this issue May 1, 2017 · 2 comments
Assignees

Comments

@jayeshkrishna
Copy link
Contributor

jayeshkrishna commented May 1, 2017

Although ./case.build --clean-all removes the build directory, cleaning for a
specific component does not work as expected (does not remove the build
directory).
This is due to changes in cime_config/cesm/machines/Makefile as part of
PR ESMCI/cime#1140 that did not make it to cime_config/acme/machines/Makefile .

See related Issues:
ESMCI/cime#1431
Fixes #1465

@jayeshkrishna
Copy link
Contributor Author

To reproduce the issue,

./create_newcase -case tmp_X_f19_g16 -compset X -res f19_g16
cd tmp_X_f19_g16
./case.setup
./case.build
/* There is Srcfiles in Depends in the atm build directory now */
./case.build --clean atm
/* The SrcFiles and Depends in the atm build directory is NOT removed */

jayeshkrishna added a commit that referenced this issue May 1, 2017
When user runs "./case.build --clean atm" some files
(Srcfiles, Depends etc) still remain in the atm build
directory.

This change was missed (changes in cesm Makefile was not ported to
the acme Makefile) in ESMCI/cime#1140

Fixes #1474
[BFB]
@rljacob
Copy link
Member

rljacob commented May 4, 2017

Please merge this.

jayeshkrishna added a commit that referenced this issue May 5, 2017
When user runs "./case.build --clean atm" some files
(Srcfiles, Depends etc) still remain in the atm build
directory.

This change was missed (changes in cesm Makefile was not ported to
the acme Makefile) in ESMCI/cime#1140

Fixes #1474
[BFB]

* jayeshkrishna/cime_clean_component:
  Make sure clean <COMPONENT> cleans up obj dir
jayeshkrishna added a commit that referenced this issue May 9, 2017
)

When user runs "./case.build --clean atm" some files
(Srcfiles, Depends etc) still remain in the atm build
directory.

This change was missed (changes in cesm Makefile was not ported to
the acme Makefile) in ESMCI/cime#1140

The branch is re-merged to include new changes to cleanup clm obj
dirs correctly.

Fixes #1474
[BFB]

* jayeshkrishna/cime_clean_component:
  Make sure clean clm cleans up obj dir
jayeshkrishna added a commit that referenced this issue May 12, 2017
When user runs "./case.build --clean atm" some files
(Srcfiles, Depends etc) still remain in the atm build
directory.

This change was missed (changes in cesm Makefile was not ported to
the acme Makefile) in ESMCI/cime#1140

Fixes #1474
[BFB]

* jayeshkrishna/cime_clean_component:
  Make sure clean clm cleans up obj dir
  Make sure clean <COMPONENT> cleans up obj dir
jgfouca pushed a commit that referenced this issue Jun 2, 2017
When user runs "./case.build --clean atm" some files
(Srcfiles, Depends etc) still remain in the atm build
directory.

This change was missed (changes in cesm Makefile was not ported to
the acme Makefile) in ESMCI/cime#1140

Fixes #1474
[BFB]
jgfouca pushed a commit that referenced this issue Jun 2, 2017
Only warning for single dash
Do not error on misuse of command line arguments, just print a warning to stderr and move on.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes

User interface changes?:

Code review:rjacob
jgfouca pushed a commit that referenced this issue Jun 2, 2017
When user runs "./case.build --clean atm" some files
(Srcfiles, Depends etc) still remain in the atm build
directory.

This change was missed (changes in cesm Makefile was not ported to
the acme Makefile) in ESMCI/cime#1140

Fixes #1474
[BFB]

* jayeshkrishna/cime_clean_component:
  Make sure clean clm cleans up obj dir
  Make sure clean <COMPONENT> cleans up obj dir
jgfouca pushed a commit that referenced this issue Feb 27, 2018
When user runs "./case.build --clean atm" some files
(Srcfiles, Depends etc) still remain in the atm build
directory.

This change was missed (changes in cesm Makefile was not ported to
the acme Makefile) in ESMCI/cime#1140

Fixes #1474
[BFB]
jgfouca pushed a commit that referenced this issue Feb 27, 2018
When user runs "./case.build --clean atm" some files
(Srcfiles, Depends etc) still remain in the atm build
directory.

This change was missed (changes in cesm Makefile was not ported to
the acme Makefile) in ESMCI/cime#1140

Fixes #1474
[BFB]

* jayeshkrishna/cime_clean_component:
  Make sure clean clm cleans up obj dir
  Make sure clean <COMPONENT> cleans up obj dir
jgfouca pushed a commit that referenced this issue Mar 14, 2018
When user runs "./case.build --clean atm" some files
(Srcfiles, Depends etc) still remain in the atm build
directory.

This change was missed (changes in cesm Makefile was not ported to
the acme Makefile) in ESMCI/cime#1140

Fixes #1474
[BFB]
jgfouca pushed a commit that referenced this issue Mar 14, 2018
When user runs "./case.build --clean atm" some files
(Srcfiles, Depends etc) still remain in the atm build
directory.

This change was missed (changes in cesm Makefile was not ported to
the acme Makefile) in ESMCI/cime#1140

Fixes #1474
[BFB]

* jayeshkrishna/cime_clean_component:
  Make sure clean clm cleans up obj dir
  Make sure clean <COMPONENT> cleans up obj dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants