Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 86400_r8 to 86400._r8 in 3 restart_dynamics files #293

Closed
singhbalwinder opened this issue Aug 4, 2015 · 7 comments · Fixed by #297
Closed

Change 86400_r8 to 86400._r8 in 3 restart_dynamics files #293

singhbalwinder opened this issue Aug 4, 2015 · 7 comments · Fixed by #297
Assignees
@singhbalwinder

Comments

@singhbalwinder
Copy link
Contributor

Bugfix (reported in cam5_4_03)
This affects eulerian dycore
components/cam/src/dynamics/eul/restart_dynamics.F90
In restart_dynamics, we have "86400_r8", which means that a real kind is being used on an integer literal. NAG complains about this, so this should be changed to "86400._r8".
This is causing CESM tests to fail. Updating the library/compiler versions and flags for hobart/NAG may reveal other, similar issues with kind numbers in CAM regression tests; right now these issues only show up when using CIME, because it was updated already, whereas the CAM Makefile and test_driver.sh script have not been updated yet.

reported by @cecilehannay
AG-331
@singhbalwinder singhbalwinder self-assigned this Aug 4, 2015
@gold2718
Copy link

gold2718 commented Aug 4, 2015

Have we made any decisions about which dycores to support? Any plan to get rid of the unsupported ones?

@singhbalwinder
Copy link
Contributor Author

I am not so sure about it, perhaps @rljacob and @mt5555 know if a decision has already been made. If we are not going to support Eulerian dycore in the future then I will close this issue without fixing the codes.

@mt5555
Copy link
Contributor

mt5555 commented Aug 5, 2015

I think this is a decision for the atmosphere group. I know we did agree to drop support for CAM4. There isn't any development in FV, but it may be useful to ensure that it still runs.

@gold2718
Copy link

gold2718 commented Aug 5, 2015

So @philrasch, are we supporting the Eulerian dycore? SLD? Should I be putting time into porting the new infrastructure to those dycores? FV?

@mt5555
Copy link
Contributor

mt5555 commented Aug 5, 2015

My vote: if you have to do additional work to support them, dont do it. But no reason to go out of our way to remove those dycores.

I could see Atmosphere wanting to retain the ability to run FV - for example when the had problems with UNICON, the ability to run FV showed that the issue was with SE tracer transport, and not in the physics.

@singhbalwinder
Copy link
Contributor Author

I talked with @philrasch and he told me that we would like to maintain FV at this point because some atmospheric team members are in transitioning phase ( FV to SE dycore). He would like everybody to move to SE dycore in the near future. @philrasch , please add if I missed anything.

@singhbalwinder
Copy link
Contributor Author

While working on fixing this bug, I found out that this bug is also present in SE dycore.

singhbalwinder added a commit that referenced this issue Aug 12, 2015
@singhbalwinder
Bug fixes from NCAR:dyn(int to real),mem alloc fixes for modal aerosols
762ff23 
This commit fixes the following bugs reported by NCAR:
- All dynamic cores had an int in the denominator of an equation which
should be real.
- There were memory allocation bugs in modal aerosol files which are
fixed. NCAR had a lot of other changes in these files. I took only the
changes which relevant to ACME codes.

See issues #293 and #292 for more details

Fixes #292, Fixes #293
[BFB]
AG-331, AG-332
@singhbalwinder singhbalwinder mentioned this issue Aug 12, 2015
Merged
susburrows added a commit that referenced this issue Aug 12, 2015
@susburrows
Merge 'singhbalwinder/atm/ncar-fixes-euldyn-water-uptake' (PR #297)
19e49c2 
Bug fixes from NCAR:dyn(int to real),mem alloc fixes for modal aerosols

This commit fixes the following bugs reported by NCAR:

- All dynamic cores had an int in the denominator of an equation which
  should be real.

- There were memory allocation bugs in modal aerosol files which are
  fixed. NCAR had a lot of other changes in these files. I took only
  the changes which are relevant to ACME codes.

See issues #293 and #292 for more details

Passes acme_developer tests.

Fixes #292, Fixes #293
[BFB]
AG-331, AG-332
susburrows added a commit that referenced this issue Aug 13, 2015
@susburrows
Merge branch 'singhbalwinder/atm/ncar-fixes-euldyn-water-uptake' (PR #…
b5504b5 
…297)

Bug fixes from NCAR:dyn(int to real),mem alloc fixes for modal aerosols

This commit fixes the following bugs reported by NCAR:

All dynamic cores had an int in the denominator of an equation which should be real.
There were memory allocation bugs in modal aerosol files which are fixed. NCAR had a lot of other changes in these files. I took only the changes which are relevant to ACME codes.
See issues #293 and #292 for more details

Fixes #292, Fixes #293
[BFB]
AG-331, AG-332
jonbob added a commit that referenced this issue Jul 1, 2019
@jonbob
Merge branch 'mark-petersen/ocean/update_mpas_source_190628' into nex…
b2b19b3 
…t (PR #3033)

Update mpas-source: COMPASS testing, whitespace, documentation

This PR updates the mpas-source submodule with changes to MPAS-Ocean for some
bfb clean-up:
* Fixes typo in particle file initialization script (MPAS-Dev/MPAS-Model #302)
* Change name coriolis to hadv_coriolis (MPAS-Dev/MPAS-Model #293)
  Note: this is internal variable and module name only, not a flag
* Stream defaults and white space corrections in xml file (MPAS-Dev/MPAS-Model #303)
  Note: does not affect E3SM
* Update README for COMPASS ocean with latest mpas_tools (MPAS-Dev/MPAS-Model #292)
* Update COMPASS for python version of JIGSAW (MPAS-Dev/MPAS-Model #301)

[BFB]
jonbob added a commit that referenced this issue Jul 2, 2019
@jonbob
Merge branch 'mark-petersen/ocean/update_mpas_source_190628' (PR #3033)
4f2ee82 
Update mpas-source: COMPASS testing, whitespace, documentation

This PR updates the mpas-source submodule with changes to MPAS-Ocean for some
bfb clean-up:
* Fixes typo in particle file initialization script (MPAS-Dev/MPAS-Model #302)
* Change name coriolis to hadv_coriolis (MPAS-Dev/MPAS-Model #293)
  Note: this is internal variable and module name only, not a flag
* Stream defaults and white space corrections in xml file (MPAS-Dev/MPAS-Model #303)
  Note: does not affect E3SM
* Update README for COMPASS ocean with latest mpas_tools (MPAS-Dev/MPAS-Model #292)
* Update COMPASS for python version of JIGSAW (MPAS-Dev/MPAS-Model #301)

[BFB]
jonbob pushed a commit that referenced this issue Jun 22, 2021
@mark-petersen
Merge PR #293 'ocean/name_hadv_coriolis' into ocean/develop
1b5a437 
The coriolis module was improperly named, as it also includes horizontal
advection of momentum.

fixes #291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@singhbalwinder singhbalwinder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug fixes from NCAR:dyn(int to real),mem alloc fixes for modal aerosols E3SM-Project/E3SM
3 participants
@gold2718 @mt5555 @singhbalwinder