Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect placement of the t_stopf() call for ecosysdyn in clm_driver.F90 #94

Closed
climate-dude opened this issue Feb 3, 2015 · 0 comments

Comments

@climate-dude
Copy link
Contributor

The t_stopf() call for ecosysdyn is misplaced in clm_driver.F90, leading to inaccurate performance data for some science cases. This issue was identified and fixed by Pat Worley in pull request #90, which also fixed issue #81. This bug was eliminated in CESM CLM tag clm4_5_1_r097 as a part of ED refactorization and was also not identified as a fixed bug in that tag. ACME has chosen not to incorporate that ED refactorization into the V1 model development, but expects to use it for V2 model development.

@climate-dude climate-dude self-assigned this Feb 3, 2015
climate-dude added a commit that referenced this issue Feb 3, 2015
eliminating reference to unallocated arrays in VOCEmissionMod (fixes #81),
moving misplaced t_stopf (fixes #94), and replacing pgi version for Titan
(fixes #62) (PR#90)

* worleyph/clm/CLM45_VOCEmissionMod_fix:
  replacing pgi/14.2.0 with pgi/14.10.home for Titan when using PGI compiler
  moving misplaced t_stopf call in CLM4.5
  eliminating reference to unallocated arrays in VOCEmissionMod

[BFB]
jgfouca pushed a commit that referenced this issue Jun 25, 2019
mwarusz pushed a commit to mwarusz/E3SM that referenced this issue Jul 1, 2024
…mega/design-omega0-time-stepping

Time Stepping Design Doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant