nprocs .gt. nelems #1121
Merged
nprocs .gt. nelems #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 24, 2016 10:18
Saving my place. Right now I still have not determined a place where nelem is set and won't cause a segfault.
This fixes the segfault when requesting more processes than elements. Now we abort the simulation and print an error message. [BFB]
My vi replaced existing tabs with spaces and I didn't notice. This is to fix the tabulation to be aligned appropriately. [BFB]
|
two requests:
|
Added a mention of dyn_pes in the error message when using more pes than elements. Also, fixed an issue where npes_cam was being used before it was set. [BFB]
|
Okay, I have fixed those issues. |
|
error message looks to be more than 128 characters, overflowing the errmsg variable. |
|
Also: format statement integer sizes (I5) are too small for nelem and par%nprocs. How about we simplify everything and just use |
Made the nprocs gt nelem error message simpler and switched from endrun to mpiabort. [BFB]
|
@mt5555 Done. |
mt5555
pushed a commit
that referenced
this pull request
Nov 10, 2016
There has been an existing issue (#1083) where we get a segfault when requesting more mpi processes than number of elements in cam. To mitigate this issue I have added an abort when this happens so that we at least don't segfault and get a nice error message which tells us what went wrong. [BFB] fixes #1083
mt5555
added a commit
that referenced
this pull request
Nov 17, 2016
There has been an existing issue (fixes #1083) where we get a segfault when requesting more mpi processes than number of elements in cam. To mitigate this issue I have added an abort when this happens so that we at least don't segfault and get a nice error message which tells us what went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been an existing issue (#1083) where we get a segfault when requesting more mpi processes than number of elements in cam. To mitigate this issue I have added an abort when this happens so that we at least don't segfault and get a nice error message which tells us what went wrong.
Eventually, the plan is to track down the underlying issue, since we are suppose to be able to use more MPI processes than elements in CAM.