compare_test_results: Support ACME's $compiler/$name baseline scheme #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfouca
deleted the
jgfouca/cime/support_acme_baseline_scheme_in_compare_test_results
branch
jgfouca
pushed a commit
that referenced
this pull request
Jun 2, 2017
Changed all arguments to short names. Updated printing for most requests, such as shorter compset output, ordered (alphabetical) compset printing, added 'all' option to compsets argument, added 'current' to machines argument but maintained previous behavior. Fixed issue where help didn't print when no arguments were provided. Also, fixed issue where a bogus value was giving to compsets and the error message printed wasn't very useful. No we print available components along with usage. Fixes #1190
jgfouca
pushed a commit
that referenced
this pull request
Jun 2, 2017
In this commit-- added the ability to give machine name as a query. Additionally, fixed some the argument descriptions. Also, fixed argument descriptions to be more descriptive on choices. Test suite: `scripts_regression_tests.py` and ``` ./query_config ./query_config --grids ./query_config --machines ./query_config --machines current ./query_config --machines redsky ./query_config --machines edison ./query_config --machines skybridge ./query_config --compsets ./query_config --compsets all ./query_config --compsets drv ./query_config --component ``` Test baseline: Test namelist changes: Test status: bit for bit Fixes #1155, #1190 User interface changes?: manage_case -> query_config --compset -> --compsets --machine -> --machines added 'all' option for --compsets added 'current' and <machine> to --machines Code review: @billsacks, @jgfouca
jgfouca
pushed a commit
that referenced
this pull request
Jun 2, 2017
* added the ability to print all compsets with argument * added the ability to print all components with and without argument * added the ability to print a specified single machine * many config_component.xml files didn't have a help string, which caused --components all not to work. * fixed some typos and gramatical errors Test suite:`scripts_regression_tests.py` and ``` ./query_config ./query_config --grids ./query_config --machines ./query_config --machines current ./query_config --machines redsky ./query_config --machines edison ./query_config --machines skybridge ./query_config --compsets ./query_config --compsets all ./query_config --compsets drv ./query_config --component ``` Test baseline: Test namelist changes: Test status: bit for bit Fixes #1155, #1190 User interface changes?: * manage_case -> query_config * --compset -> --compsets * --machine -> --machines * added 'all' option for --compsets * added 'current' to --machines * added <machine> to --machines * added 'all' to --component * default for --component and --compsets is 'all' Code review: @billsacks, @jgfouca, @jedwards4b, @rljacob
jgfouca
pushed a commit
that referenced
this pull request
Jun 2, 2017
Renamed manage_case to query_config. Additionally, changed all references to manage_case to query_config. Added ability to query current machine and a single machine. Added 'all' option to --compsets. Made the help message much more useful. Test suite: scripts_regression_tests.py and ./query_config ./query_config --grids ./query_config --machines ./query_config --machines current ./query_config --machines redsky ./query_config --machines edison ./query_config --machines skybridge ./query_config --compsets ./query_config --compsets all ./query_config --compsets drv ./query_config --component Test baseline: Test namelist changes: Test status: bit for bit Fixes #1155 Fixes #1190 User interface changes?: manage_case -> query_config --compset -> --compsets --machine -> --machines added 'all' option for --compsets added 'current' and to --machines Code review: @billsacks, @jgfouca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BFB]