Ensures MPAS AM write/compute startup steps are performed #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonbob, Does this mean a line like
* fixes write/compute step on startup behavior for MPAS-O AMs (bug fix in driver)
|
|
Oh, I just meant a comment in the Fortran code |
This is to fix a bug in the ACME where startup computation and writing did not work for AMs. A call to `ocn_analysis_compute_startup` was previously missing
pwolfram
force-pushed
the
pwolfram/ocn/fix_AM_write_on_startup
branch
from
c34ec71 to
c00cde8
Compare
|
@jonbob, thanks for catching that-- it is much better with a comment! |
|
@pwolfram -- certainly not important, but maybe more clear. Thanks! |
|
@pwolfram -- one more quick question. I've been testing an implementation of this in mpas-seaice, but in that case, the call to cice_analysis_compute_startup is done at the end of the init_mct routine instead of in the run_mct routine. It will only get called once that way, while in the ocn it will be called every timestep. Do you think it's necessary to call it for every step? In the standalone ocn driver, it only gets called once.... |
|
This issue was closed by #1257 |
agsalin
pushed a commit
that referenced
this pull request
Apr 13, 2017
fix issue with compset not printing to timing file Get_timing was using the old CCSM_COMPSET name instead of just COMPSET Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: bit for bit Fixes #1191 User interface changes?: Code review:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge fixes a bug in the ACME for MPAS-O analysis members (AMs)
where startup computation and writing did not work for AMs because a call to
ocn_analysis_compute_startupwas previously missing.Dycore results should be BFB. However, AM results may not necessarily
be BFB.
Addresses #1185. Assumes MPAS-O PR MPAS-Dev/MPAS#1179 has been fulfilled.
cc @jonbob