Add expect statement for jobid search #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This search must succeed. In the previous code, we get a nasty and mostly useless stacktrace. With this change, we should get an informative error message. [BFB]
jgfouca
added a commit
that referenced
this pull request
Jan 8, 2017
Add expect statement for jobid search This search must succeed. In the previous code, we get a nasty and mostly useless stacktrace. With this change, we should get an informative error message. [BFB] * jgfouca/cime/jobid_fail_err_msg: Add expect statement for jobid search
jgfouca
added a commit
that referenced
this pull request
Jan 8, 2017
Add expect statement for jobid search This search must succeed. In the previous code, we get a nasty and mostly useless stacktrace. With this change, we should get an informative error message. [BFB] * jgfouca/cime/jobid_fail_err_msg: Add expect statement for jobid search
jgfouca
added a commit
that referenced
this pull request
Jan 8, 2017
Add expect statement for jobid search This search must succeed. In the previous code, we get a nasty and mostly useless stacktrace. With this change, we should get an informative error message. [BFB] * jgfouca/cime/jobid_fail_err_msg: Add expect statement for jobid search
jgfouca
added a commit
that referenced
this pull request
Jan 8, 2017
Add expect statement for jobid search This search must succeed. In the previous code, we get a nasty and mostly useless stacktrace. With this change, we should get an informative error message. [BFB] * jgfouca/cime/jobid_fail_err_msg: Add expect statement for jobid search
agsalin
pushed a commit
that referenced
this pull request
Apr 13, 2017
update compare_xml to find more differences The subnode of entry id nodes was not being checked with compare_xml and so changes to the pelayout were not being trapped by check_lockedfiles Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: bit for bit Fixes #1205 User interface changes?: Code review:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This search must succeed. In the previous code, we get a nasty
and mostly useless stacktrace. With this change, we should get
an informative error message.
[BFB]