Fix incorrect CMPASO and GMPAS compsets in CIME5 #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonbob
added
bug fix PR
CIME
compset
non-BFB
jonbob
added a commit
that referenced
this pull request
Jan 10, 2017
Fix incorrect CMPASO and GMPAS compsets in CIME5 In moving from CIME2 to CIME5, the MPAS compsets were incorrectly translated and need to be fixed. The CMPASO compsets are currently defined to include active MPAS-CICE (which makes them G compsets) instead of DICE, while one of the GMAS compsets is missing and the other is misnamed. The results will not be BFB but only for CMPASO tests, since the components used will change back to the correct set. This should not impact fully-coupled results. [non-BFB] [FCC]
jonbob
added a commit
that referenced
this pull request
Jan 12, 2017
Fix incorrect CMPASO and GMPAS compsets in CIME5 CIME5 has incorrect definitions for CMPASO and GMPAS compsets In moving from CIME2 to CIME5, the MPAS compsets were incorrectly translated and need to be fixed. The CMPASO compsets are currently defined to include active MPAS-CICE (which makes them G compsets) instead of DICE, while one of the GMAS compsets is missing and the other is misnamed. The results will not be BFB but only for CMPASO tests, since the components used will change back to the correct set. This should not impact fully-coupled results. Fixes #1208 [non-BFB] [FCC] * origin/jonbob/mpas/fix-compsets: Fix CMPASO and GMPAS compsets that were incorrectly brought in with CIME5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CIME5 has incorrect definitions for CMPASO and GMPAS compsets
In moving from CIME2 to CIME5, the MPAS compsets were incorrectly translated and need to be fixed. The CMPASO compsets are currently defined to include active MPAS-CICE (which makes them G compsets) instead of DICE, while one of the GMAS compsets is missing and the other is misnamed. The results will not be BFB but only for CMPASO tests, since the components used will change back to the correct set. This should not impact fully-coupled results. Resolves Issue #1208 .
[non-BFB]
[FCC]