-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Richardson number smoothing to CVMix in mpas-o #1265
Conversation
2b546d8
to
0303244
Compare
0303244
to
d7f5038
Compare
Add Richardson number smoothing to CVMix in mpas-o This PR implements @vanroekel's smoothing of the Richardson number profile prior to computing LMD94 shear instability mixing (see MPAS 1219). This reduces the frequency of 2 dz (grid-scale) noise in viscosity/diffusivity profiles. It also includes new default ICG files for the oEC60to30v3_ICG ice/ocn grid, which have been spun-up with this fix, to provide consistent initial conditions for its use. A flag for the number of smoothing loops is also implemented, but should not normally need to be changed from the default in registry. Finally the limiting of the Ri profile to be positive is removed as this check is also performed in CVMix. Tested with SMS.ne30_oECv3_ICG.A_WCYCL2000S.edison_intel. [CC] [NML]
Pushed to next |
Running a longer, five-year test on anvil of A_WCYCL2000S.ne30_oECv3_ICG, to check the new ocn/ice initial conditions from a G-case that also had the Richardson number smoothing included. |
After review of the five-year A_WCYCL2000S.ne30_oECv3_ICG run, we feel comfortable with the code changes and will move them to master. However, the new default initial conditions for this configuration will probably require a new G-case spin-up that includes this Richardson number smoothing from the very onset. So we will recommend to @golaz that no long runs be made with them until we can replace them. |
Add Richardson number smoothing to CVMix in mpas-o This PR implements @vanroekel's smoothing of the Richardson number profile prior to computing LMD94 shear instability mixing (see MPAS 1219). This reduces the frequency of 2 dz (grid-scale) noise in viscosity/diffusivity profiles. It also includes new default ICG files for the oEC60to30v3_ICG ice/ocn grid, which have been spun-up with this fix, to provide consistent initial conditions for its use. A flag for the number of smoothing loops is also implemented, but should not normally need to be changed from the default in registry. Finally the limiting of the Ri profile to be positive is removed as this check is also performed in CVMix. Tested with SMS.ne30_oECv3_ICG.A_WCYCL2000S.edison_intel and five-year run of A_WCYCL2000S.ne30_oECv3_ICG.anvil [CC] [NML]
Pushed to master |
Master was closed today and this should not have been committed. The branch will be reconstituted and the commit removed with a force push. |
Sorry -- I misread @wadeburgess's email this morning. My apologies. |
Yes it will go on master later. Github won't let you re-open a PR so a new one was made for the same branch. |
The configure script has been updated so the directions in INSTALL were a little out of date. (This will need to be updated again after issue #1265 is closed.) Also updated the clean target to also remove executable (removing need for realclean target) and the distclean target to clean up after configure.
This PR implements @vanroekel's smoothing of the Richardson number profile prior to computing
LMD94 shear instability mixing (see MPAS 1219). This reduces the frequency of 2 dz (grid-scale) noise in viscosity/diffusivity profiles
A flag for the number of smoothing loops is also implemented, but should not normally need to be
changed from the default in registry.
Finally the limiting of the Ri profile to be positive is removed as this check is also performed in CVMix.
Tested with SMS.ne30_oECv3_ICG.A_WCYCL2000S.edison_intel.
[CC]
[NML]