Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Richardson number smoothing to CVMix in mpas-o #1265

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

jonbob
Copy link
Contributor

@jonbob jonbob commented Feb 13, 2017

This PR implements @vanroekel's smoothing of the Richardson number profile prior to computing
LMD94 shear instability mixing (see MPAS 1219). This reduces the frequency of 2 dz (grid-scale) noise in viscosity/diffusivity profiles

A flag for the number of smoothing loops is also implemented, but should not normally need to be
changed from the default in registry.

Finally the limiting of the Ri profile to be positive is removed as this check is also performed in CVMix.

Tested with SMS.ne30_oECv3_ICG.A_WCYCL2000S.edison_intel.

[CC]
[NML]

@jonbob jonbob added Coupled Model NML non-BFB PR makes roundoff changes to answers. mpas-ocean labels Feb 13, 2017
jonbob added a commit that referenced this pull request Feb 14, 2017
Add Richardson number smoothing to CVMix in mpas-o

This PR implements @vanroekel's smoothing of the Richardson number profile prior
to computing LMD94 shear instability mixing (see MPAS 1219). This reduces the
frequency of 2 dz (grid-scale) noise in viscosity/diffusivity profiles.  It also
includes new default ICG files for the oEC60to30v3_ICG ice/ocn grid, which have
been spun-up with this fix, to provide consistent initial conditions for its
use.

A flag for the number of smoothing loops is also implemented, but should not
normally need to be changed from the default in registry.

Finally the limiting of the Ri profile to be positive is removed as this check
is also performed in CVMix.

Tested with SMS.ne30_oECv3_ICG.A_WCYCL2000S.edison_intel.

[CC]
[NML]
@jonbob
Copy link
Contributor Author

jonbob commented Feb 14, 2017

Pushed to next

@rljacob rljacob added this to the v1.0beta1 milestone Feb 14, 2017
@jonbob
Copy link
Contributor Author

jonbob commented Feb 15, 2017

Running a longer, five-year test on anvil of A_WCYCL2000S.ne30_oECv3_ICG, to check the new ocn/ice initial conditions from a G-case that also had the Richardson number smoothing included.

@jonbob
Copy link
Contributor Author

jonbob commented Feb 16, 2017

After review of the five-year A_WCYCL2000S.ne30_oECv3_ICG run, we feel comfortable with the code changes and will move them to master. However, the new default initial conditions for this configuration will probably require a new G-case spin-up that includes this Richardson number smoothing from the very onset. So we will recommend to @golaz that no long runs be made with them until we can replace them.

@jonbob jonbob merged commit d7f5038 into master Feb 16, 2017
jonbob added a commit that referenced this pull request Feb 16, 2017
Add Richardson number smoothing to CVMix in mpas-o

This PR implements @vanroekel's smoothing of the Richardson number profile prior
to computing LMD94 shear instability mixing (see MPAS 1219). This reduces the
frequency of 2 dz (grid-scale) noise in viscosity/diffusivity profiles. It also
includes new default ICG files for the oEC60to30v3_ICG ice/ocn grid, which have
been spun-up with this fix, to provide consistent initial conditions for its
use.

A flag for the number of smoothing loops is also implemented, but should not
normally need to be changed from the default in registry.

Finally the limiting of the Ri profile to be positive is removed as this check
is also performed in CVMix.

Tested with SMS.ne30_oECv3_ICG.A_WCYCL2000S.edison_intel and five-year run of
A_WCYCL2000S.ne30_oECv3_ICG.anvil

[CC]
[NML]
@jonbob
Copy link
Contributor Author

jonbob commented Feb 16, 2017

Pushed to master

@jonbob jonbob deleted the jonbob/ocean/CVMix_SmoothRi branch February 16, 2017 19:16
@jgfouca jgfouca restored the jonbob/ocean/CVMix_SmoothRi branch February 16, 2017 21:41
@rljacob
Copy link
Member

rljacob commented Feb 16, 2017

Master was closed today and this should not have been committed. The branch will be reconstituted and the commit removed with a force push.

@jonbob
Copy link
Contributor Author

jonbob commented Feb 16, 2017

Sorry -- I misread @wadeburgess's email this morning. My apologies.

@golaz
Copy link
Contributor

golaz commented Feb 16, 2017

@rljacob : I'm confused since I don't have access to the email mentioned. Will this go on master later? I see there is another related PR #1275.

@rljacob
Copy link
Member

rljacob commented Feb 17, 2017

Yes it will go on master later. Github won't let you re-open a PR so a new one was made for the same branch.

@jonbob jonbob deleted the jonbob/ocean/CVMix_SmoothRi branch February 21, 2017 18:16
@rljacob rljacob removed this from the v1.0beta1 milestone Mar 1, 2017
agsalin pushed a commit that referenced this pull request Apr 13, 2017
The configure script has been updated so the directions in INSTALL were a
little out of date. (This will need to be updated again after issue #1265 is
closed.) Also updated the clean target to also remove executable (removing need
for realclean target) and the distclean target to clean up after configure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Coupled Model mpas-ocean NML non-BFB PR makes roundoff changes to answers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants