Restore optimized num nodes. #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On titan, the aprun command is now correct but num_nodes was incorrect due to not using the 'optimized' num nodes that task maker was programmed to use with aprun long ago. This commit restores that capability. [BFB]
|
@jgfouca and @amametjanov , I am leaving on vacation tomorrow, and won't be able to get to this in a timely fashion. Az, as you identified the problem originally, I hope that you will be willing to integrate this as well. |
|
@worleyph was this a planned vacation or is the SE team making you want to cut loose? |
|
:-) - no, a real vacation, though, being "retired", vacation is a funny concept. Planned trip to visit relatives. How about "non-ACME travel with limited network access". |
|
Did case.setup on the same PE layout from the original issue. Latest git master (v1.0.0-beta.1-80-g48fc6b3) shows which is incorrect. After switching to this branch and Machine-specific BFB update: skipping integration tests. |
amametjanov
approved these changes
Mar 28, 2017
amametjanov
added a commit
that referenced
this pull request
Mar 28, 2017
Restore optimized num nodes: On titan, the aprun command is now correct but num_nodes was incorrect due to not using the 'optimized' num nodes that task maker was programmed to use with aprun long ago. This commit restores that capability. Fixes #1255 [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On titan, the aprun command is now correct but num_nodes was
incorrect due to not using the 'optimized' num nodes that task maker
was programmed to use with aprun long ago. This commit restores
that capability.
Fixes #1255
[BFB]