Guard against div-by-zero in memory baseline comparison #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fail the MEMCOMP phase if the baseline memory is zero. [BFB]
|
Don't most of our baselines have 0 for memory usage because the routine to find the memory doesn't work? This will lead to fails all over the place. |
|
@rljacob that's OK, we mostly ignore MEMCOMP fails anyway. |
amametjanov
approved these changes
Apr 1, 2017
amametjanov
added a commit
that referenced
this pull request
Apr 1, 2017
Guard against div-by-zero in memory baseline comparison: Fail the MEMCOMP phase if the baseline memory is zero. Fixes #1349 [BFB]
|
Merged to next. |
|
@amametjanov merge to master? |
amametjanov
added a commit
that referenced
this pull request
Apr 5, 2017
Guard against div-by-zero in memory baseline comparison: Fail the MEMCOMP phase if the baseline memory is zero. Fixes #1349 [BFB]
agsalin
pushed a commit
that referenced
this pull request
May 1, 2017
Make Machines.get_value more likely to return values of the correct type
jgfouca
pushed a commit
that referenced
this pull request
Jun 2, 2017
Guard against div-by-zero in memory baseline comparison: Fail the MEMCOMP phase if the baseline memory is zero. Fixes #1349 [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Feb 27, 2018
Guard against div-by-zero in memory baseline comparison: Fail the MEMCOMP phase if the baseline memory is zero. Fixes #1349 [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Mar 14, 2018
Guard against div-by-zero in memory baseline comparison: Fail the MEMCOMP phase if the baseline memory is zero. Fixes #1349 [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail the MEMCOMP phase if the baseline memory is zero.
Fixes #1349
[BFB]