Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on FORT_BUFFERED on Edison #1398

Merged
merged 1 commit into from
May 4, 2017
Merged

Turn on FORT_BUFFERED on Edison #1398

merged 1 commit into from
May 4, 2017

Conversation

amametjanov
Copy link
Member

This variable used to be set and was removed on 2017-03-16, because Intel v17 was failing when it was set. When it is not set, throughput with Edison's Intel v15 suffers.

Addresses #1387
[BFB]

@amametjanov amametjanov added BFB PR leaves answers BFB Edison labels Apr 12, 2017
@amametjanov amametjanov mentioned this pull request Apr 12, 2017
Closed
@ndkeen
Copy link
Contributor

ndkeen commented Apr 14, 2017

I ran acme_developer, but one test failed ERS.f19_g16.I1850CLM45.edison_intel.clm-betr. It was a runtime failure and I found a trace using ATP, but it seemed like some odd memory issue. I recompiled debug and it passed. I re-ran without FORT_BUFFERED and it failed, so I don't think it's related to this env variable. I see that the test passed on CDASH and with a previous acme_developer I ran. So I think we can merge this and I can try a fresh attempt at looking at this test later.

ndkeen added a commit that referenced this pull request Apr 14, 2017
@ndkeen
Merge branch 'azamat/edison/fort_buffered' into next (PR #1398)
d05349f 
This variable used to be set and was removed on 2017-03-16, because Intel v17 was failing when it was set. When it is not set, throughput with Edison's Intel v15 suffers.

Addresses #1387
[BFB]
@ndkeen
Copy link
Contributor

ndkeen commented Apr 14, 2017

merged to next

@rljacob
Copy link
Member

rljacob commented May 4, 2017

@ndkeen merge this to master.

@ndkeen ndkeen merged commit ee48820 into master May 4, 2017
ndkeen added a commit that referenced this pull request May 4, 2017
@ndkeen
Merge branch 'azamat/edison/fort_buffered' (PR #1398)
e151f8e 
This variable used to be set and was removed on 2017-03-16, because Intel v17 was failing when it was set. When it is not set, throughput with Edison's Intel v15 suffers.

Addresses #1387
[BFB]
jgfouca pushed a commit that referenced this pull request Jun 2, 2017
@ndkeen
Merge branch 'azamat/edison/fort_buffered' (PR #1398)
5140655 
This variable used to be set and was removed on 2017-03-16, because Intel v17 was failing when it was set. When it is not set, throughput with Edison's Intel v15 suffers.

Addresses #1387
[BFB]
@amametjanov amametjanov deleted the azamat/edison/fort_buffered branch June 2, 2017 23:58
jgfouca pushed a commit that referenced this pull request Feb 27, 2018
@ndkeen
Merge branch 'azamat/edison/fort_buffered' (PR #1398)
7b92d18 
This variable used to be set and was removed on 2017-03-16, because Intel v17 was failing when it was set. When it is not set, throughput with Edison's Intel v15 suffers.

Addresses #1387
[BFB]
jgfouca pushed a commit that referenced this pull request Mar 14, 2018
@ndkeen
Merge branch 'azamat/edison/fort_buffered' (PR #1398)
cb06b5e 
This variable used to be set and was removed on 2017-03-16, because Intel v17 was failing when it was set. When it is not set, throughput with Edison's Intel v15 suffers.

Addresses #1387
[BFB]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ndkeen ndkeen

Labels
BFB PR leaves answers BFB Edison
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amametjanov @ndkeen @rljacob