Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning out deprecated hooks into FATES (ED). #1423

Conversation

rgknox
Copy link
Contributor

@rgknox rgknox commented Apr 19, 2017

In this change-set, like the title implies, the old and obsolete ED code was removed.
Likewise, the various interface connection points were also cleaned.

[BFB]

rgknox and others added 5 commits April 13, 2017 14:33
…shaded versus non-shaded canopy for radiation. This was removed from SurfaceRadiation() and given its own subroutine so that the calculation for the fates and non-fates case can be split at the level of clm_driv(), which makes for a cleaner interface between fates and alm.
@rgknox
Copy link
Contributor Author

rgknox commented Apr 19, 2017

Some specifics:

  1. In surface radiation calculations, there was code nested two calls away from clm_drv where sun-shade fractions are calculated in different ways depending on if FATES is turned on or off, this portion of the code was split off and two completely different subroutines are called for fates and non-fates runs.
  2. the land model will use a patch/pft level data structure called "itype", this indicates what kind of land-cover is represented by the patch. FATES assumes that different plants co-exist inside patches, and thus the use of itype is incompatible with fates. Instances where itype is used in alm code need to be filtered for non-fates patches.

There may be a few more things to be cleaned out or prepped before FATES is integrated into ALM fully, but this changeset accomplishes the bulk of the "cleaning out the old", so seemed like a good cut off point.

Developers note: This is my first PR with the ACME team, so apologies if my protocol is lacking, I will do my best to learn your system. I do note that my commit messages are pretty lackluster. I will improve on these in the commits to come!

bishtgautam pushed a commit that referenced this pull request Apr 20, 2017
…nto next (PR #1423)

In this change-set, like the title implies, the old and obsolete ED code was removed.
Likewise, the various interface connection points were also cleaned.

[BFB]
@bishtgautam bishtgautam merged commit 187fe23 into E3SM-Project:master Apr 21, 2017
bishtgautam pushed a commit that referenced this pull request Apr 21, 2017
…ning' (PR #1423)

In this change-set, like the title implies, the old and obsolete ED code was removed.
Likewise, the various interface connection points were also cleaned.

[BFB]
agsalin pushed a commit that referenced this pull request May 1, 2017
Move unit tests to scripts/fortran_unit_testing
Moves unit testing infrastructure from tools/unit_testing to
scripts/fortran_unit_testing.

Rationale: tools are supposed to be optional tools, whereas the Fortran
unit tests are a more required part of the testing workflow.

Also cleans up python in fortran_unit_testing directory:

Remove dead code (which has been replaced by use of the standard CIME
utilities)

Clean up pylint problems

Also updates some documentation

Test suite: scripts_regression_tests on yellowstone
Test baseline: n/a
Test namelist changes: n/a
Test status: bit for bit

Fixes #1423
Fixes #1424

User interface changes?: Moves run_tests.py to scripts/fortran_unit_testing

Code review: jedwards
jgfouca pushed a commit that referenced this pull request Jun 2, 2017
…ning' (PR #1423)

In this change-set, like the title implies, the old and obsolete ED code was removed.
Likewise, the various interface connection points were also cleaned.

[BFB]
jgfouca pushed a commit that referenced this pull request Feb 27, 2018
…ning' (PR #1423)

In this change-set, like the title implies, the old and obsolete ED code was removed.
Likewise, the various interface connection points were also cleaned.

[BFB]
jgfouca pushed a commit that referenced this pull request Mar 14, 2018
…ning' (PR #1423)

In this change-set, like the title implies, the old and obsolete ED code was removed.
Likewise, the various interface connection points were also cleaned.

[BFB]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB Land Machine Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants