-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning out deprecated hooks into FATES (ED). #1423
Cleaning out deprecated hooks into FATES (ED). #1423
Conversation
…shaded versus non-shaded canopy for radiation. This was removed from SurfaceRadiation() and given its own subroutine so that the calculation for the fates and non-fates case can be split at the level of clm_driv(), which makes for a cleaner interface between fates and alm.
Some specifics:
There may be a few more things to be cleaned out or prepped before FATES is integrated into ALM fully, but this changeset accomplishes the bulk of the "cleaning out the old", so seemed like a good cut off point. Developers note: This is my first PR with the ACME team, so apologies if my protocol is lacking, I will do my best to learn your system. I do note that my commit messages are pretty lackluster. I will improve on these in the commits to come! |
…nto next (PR #1423) In this change-set, like the title implies, the old and obsolete ED code was removed. Likewise, the various interface connection points were also cleaned. [BFB]
…ning' (PR #1423) In this change-set, like the title implies, the old and obsolete ED code was removed. Likewise, the various interface connection points were also cleaned. [BFB]
Move unit tests to scripts/fortran_unit_testing Moves unit testing infrastructure from tools/unit_testing to scripts/fortran_unit_testing. Rationale: tools are supposed to be optional tools, whereas the Fortran unit tests are a more required part of the testing workflow. Also cleans up python in fortran_unit_testing directory: Remove dead code (which has been replaced by use of the standard CIME utilities) Clean up pylint problems Also updates some documentation Test suite: scripts_regression_tests on yellowstone Test baseline: n/a Test namelist changes: n/a Test status: bit for bit Fixes #1423 Fixes #1424 User interface changes?: Moves run_tests.py to scripts/fortran_unit_testing Code review: jedwards
…ning' (PR #1423) In this change-set, like the title implies, the old and obsolete ED code was removed. Likewise, the various interface connection points were also cleaned. [BFB]
…ning' (PR #1423) In this change-set, like the title implies, the old and obsolete ED code was removed. Likewise, the various interface connection points were also cleaned. [BFB]
…ning' (PR #1423) In this change-set, like the title implies, the old and obsolete ED code was removed. Likewise, the various interface connection points were also cleaned. [BFB]
In this change-set, like the title implies, the old and obsolete ED code was removed.
Likewise, the various interface connection points were also cleaned.
[BFB]