-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates VSFM and adds EMI #1460
Commits on Apr 24, 2017
-
Adds namelist option to specify domain decompisition for ALM.
- domain_decomp_type = 'round_robin' [Default] = 'graph_partitioning' [New scheme] - Presently domain_decomp_type is only read from namelist file, but not used within ALM
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 4eb164b - Browse repository at this point
Copy the full SHA 4eb164bView commit details -
Adds a subroutine in ALM to read grid-to-grid connectivity
- If lateral_connectivity = .true., the code attempts to read grid-to-grid connectivity information from the domain file. - This grid-to-grid connectivity information for ALM: - Follows the convention used by MPAS. - Is saved as cellsOnCell data field within the domain netcdf file. - dimname(cellsOnCell) = {'nCells','maxEdges'}
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for cb8c79f - Browse repository at this point
Copy the full SHA cb8c79fView commit details -
Adds support for decomposing ALM grid via graph partitioning
- Graph Partitioning (GP) requires PETSc. - Presently, GP is only implemented for ALM grid with no inactive grid cells.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 7aaa21a - Browse repository at this point
Copy the full SHA 7aaa21aView commit details -
Consolidates the initialization of PETSc in ALM
Both, VSFM and framework for lateral subsurface connectivity require PETSc. Thus, a new subourtine is added that consolidates the initialization of PETSc.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for b649382 - Browse repository at this point
Copy the full SHA b649382View commit details -
Initial implementation of a lateral connectivity framework for ALM
- The framework requires PETSc. - It is based of the unstructured grid framework implemented in PFLOTRAN.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for dec015c - Browse repository at this point
Copy the full SHA dec015cView commit details -
Adds subroutines to get/set values for ALM subgrid categories
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 480f0f5 - Browse repository at this point
Copy the full SHA 480f0f5View commit details -
Adds more functionality for laterally connected ALM domain
- Adds to exchange data for ghost/halo grid cells across MPI ranks. - Adds subroutine to free up memory
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for fe467ce - Browse repository at this point
Copy the full SHA fe467ceView commit details -
Adds update of ALM's ghost subgrid structure
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 30d898e - Browse repository at this point
Copy the full SHA 30d898eView commit details -
Fixes preprocessor statement in ALM-VSFM
- NAG returns an error with the file is empty
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 9f10c65 - Browse repository at this point
Copy the full SHA 9f10c65View commit details -
Adds subroutine to count ALM ghost subgrid hierarchy
Counts up ghost gridcells, landunits, columns, and pfts on each MPI task
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for e383c89 - Browse repository at this point
Copy the full SHA e383c89View commit details -
Adds x/y field for each ALM grid cell
Reads in x/y fields (in meters), if 'xCell'/'yCell' field are present within the domain netCDF
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for cadd6ae - Browse repository at this point
Copy the full SHA cadd6aeView commit details -
Updates the check for ALM ghost subgrid hierarchy
Adds a check for ghost/halo grid-to-landunit mapping
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for ee455de - Browse repository at this point
Copy the full SHA ee455deView commit details -
Adds subroutine to exchange column-level ALM across MPI tasks
- Each MPI task can get ghost/halo column level data from it's neighbor. - The subroutine needs to be called outside OpenMP/clump loop
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for c46719c - Browse repository at this point
Copy the full SHA c46719cView commit details -
Fixes the mapping of neighboring grid cells in ALM
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 6aa2c7c - Browse repository at this point
Copy the full SHA 6aa2c7cView commit details -
Assigns soil properties to ghost/halo colums in ALM
- Memory is allocated for ghost/halo columns for the following soil properties: - watsat : porosity - hksat : hydraulic conductivity - bsw : Clapp and Hornberger parameter - sucsat : minimum soil suction - Data for the above mentioned soil properties is exchanges among MPI tasks
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 4995927 - Browse repository at this point
Copy the full SHA 4995927View commit details -
Updates to equation-of-state in ALM for VSFM
Modified the TGDB01 EOS w.r.t pressure. Pressure is now only accounted in the computation of density of water when pressure is greater than reference pressure. In other words, pressure only affects water density under saturated conditions.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 26eede2 - Browse repository at this point
Copy the full SHA 26eede2View commit details -
Adds initial infrastructre to support lateral subsurface flow in ALM
The initial infrastructure includes: - Setup of column-level lateral connectivity of subsurface mesh for VSFM. - For an operator split approach of solving VSFM, adds a subroutine to compute the lateral flux. - Updates to the 1D VSFM solver to account of lateral flux. Note: - Column level lateral connection are only set between columns of istsoil type. - Though, VSFM solver can now account for lateral flux, the SoilWaterMovementMod() isn't updated at this stage to allow lateral transport because mass-balance check needs to be updated.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for b3df051 - Browse repository at this point
Copy the full SHA b3df051View commit details -
ALM reads additional data specified in MPAS format
If lateral_connectivity is true, following additional data are read from land domain file - edgesOnCell - nEdgesOnCell - areaCell - dcEdge - dvEdge
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for fe3c8fa - Browse repository at this point
Copy the full SHA fe3c8faView commit details -
Updates to ALM suburface mesh for VSFM
ALM subsurface mesh now accounts for geometric attributes read in using MPAS format. These new attributes (distance between grid cells, distance of edge shared by grid cells, and area of grid cell) are required when lateral_connectivity is set as true.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 929e4e7 - Browse repository at this point
Copy the full SHA 929e4e7View commit details -
Minor ALM modifications to avoid compiler failures
Modifications for the case when flag -DUSE_PETSC_LIB is not specified.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 0d8f798 - Browse repository at this point
Copy the full SHA 0d8f798View commit details -
Adds seepage face BC in ALM VSFM solver
- In 1D-flow, infiltration is shut off if the top soil layer is fully saturated. Thus, the liquid pressure in the soil column could only go slightly above atmospheric pressure at max. - When lateral flows are turned on, seepage face boundary condition is needed to allow for exfiltration from the soil column.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 4d6f9b9 - Browse repository at this point
Copy the full SHA 4d6f9b9View commit details -
Turns on lateral subsurface flow in ALM
- When lateral_connectivity = .true., lateral flows between soil columns is allowed in the VSFM solver.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 171a4e9 - Browse repository at this point
Copy the full SHA 171a4e9View commit details -
Updates VSFM solver in ALM to saves internal/boundary mass flux
- The flux is computed between 'upwind' and 'downwind' control volumes. - Negative values of flux implies, flow occurs from upwind to downwind control volume
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for b8ea024 - Browse repository at this point
Copy the full SHA b8ea024View commit details -
Adds options to include lateral flows in VSFM
Following three options are added: - none = No lateral flow - source_sink = 1D VSFM solution + Lateral flow modeled as source/sink term - three_dimensional = 3D VSFM solution (only supported for serial run)
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for d647435 - Browse repository at this point
Copy the full SHA d647435View commit details -
Updates VSFM solver tolerance after an unacceptable solution
When a solution is unacceptable due to mass balance error threshold, reduce PETSc SNES tolerance (solution [stol] or relative [rtol]) depending on the reason for the convergance of SNES.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 4c0c545 - Browse repository at this point
Copy the full SHA 4c0c545View commit details -
Restructures VSFM subdirectory in ALM
- Renames VSFM subdirectory to MPP (Multi-Physics-Problems), since the VSFM approach is planned to be used for other physics scheme. - Creates subdirectories within MPP top level directory - dtypes: For data types - vsfm : For VSFM - util : For utilities - Updates ALM build script [BFB]
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 3e2e061 - Browse repository at this point
Copy the full SHA 3e2e061View commit details -
Fixes the initialization of lateral flux in ALM.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 86772f2 - Browse repository at this point
Copy the full SHA 86772f2View commit details -
Splits ALM's thermal model for non-urban and urban cols
In order to support future developments, the ALM thermal model is split into two: - For non-urban columns, and - For Urban columns [BFB]
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 67b7739 - Browse repository at this point
Copy the full SHA 67b7739View commit details -
Adds a runtime option to specify ALM thermal model
An option to specify PETSc-based thermal model (use_petsc_thermal_model) is added. Presently, the PETSc-based thermal model is not supported.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for c26e2ad - Browse repository at this point
Copy the full SHA c26e2adView commit details -
Initial checkin of PETSc-based thermal model for ALM
- Adds a PETSc based linear solver for the thermal model comprising of the following components: - Snow, - Standing surface water, and - Soil - The PETSc based model uses the same physics formulation as the default ALM model. - DMComposite() from PETSc is used to assembly: - Diagonal block matrix: accounts for interactings within a component, and - Off-diagonal block matrix: accounts for interactins across compoents.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 4dbff9b - Browse repository at this point
Copy the full SHA 4dbff9bView commit details -
ALM-MPP refactor to reduce dependency on CLM
Removes unnecessary dependency of ALM-MPP on the following CLM modules: - clm_time_manager - column_varcon - decompMod - shr_infnan_mod - shr_kind_mod - spmdMod - ColumnType - EnergyFluxType - GridcellType - LandunitType - SoilHydrologyType - SoilStateType - TemperatureType - WaterstateType
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 3667265 - Browse repository at this point
Copy the full SHA 3667265View commit details -
Round-2 of ALM-MPP refactor to reduce dependency on CLM
Removes unnecessary dependency of ALM-MPP on the following CLM modules: - clm_varcon - clm_varctl - clm_varpar - shr_log_mod
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 2af72db - Browse repository at this point
Copy the full SHA 2af72dbView commit details -
Makes the file names be consistent with module name
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for c6ca96f - Browse repository at this point
Copy the full SHA c6ca96fView commit details -
Round-3 of ALM-MPP refactor to reduce dependency on CLM
Removes unnecessary dependency of ALM-MPP on the following CLM modules: - abortutils
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 44a791e - Browse repository at this point
Copy the full SHA 44a791eView commit details -
Round-4 of ALM-MPP refactor to reduce dependency on CLM
Removes unnecessary dependency of ALM-MPP on the following CLM modules: - domainLateralMod
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for c1ea2ec - Browse repository at this point
Copy the full SHA c1ea2ecView commit details -
Minor fixes to the ALM-MPP refactor
Removes few outstanding unnecessary dependency of ALM-MPP on CLM modules
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for e071169 - Browse repository at this point
Copy the full SHA e071169View commit details -
Major refactor of ALM PETSc-based thermal model
This refactor removes the hard coded setup of the ALM's PETSc based thermal model from the MPP (multi-physics-problem) library. The setup of MPP problem for ALM now occurs in the biophysics/mpp/driver/alm directory and setup of other problems for benchmark and verification will occur in the biophysics/mpp/driver directory.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 7600a8f - Browse repository at this point
Copy the full SHA 7600a8fView commit details -
Adds a subroutine in VSFM to set MPI rank
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 4b92f6a - Browse repository at this point
Copy the full SHA 4b92f6aView commit details -
This refactor removes the hard coded setup of the ALM's VSFM from the MPP (multi-physics-problem) library. The setup of MPP problem for ALM now occurs in the biophysics/mpp/driver/alm directory and setup of other problems for benchmark and verification will occur in the biophysics/mpp/driver directory.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for d2fbdae - Browse repository at this point
Copy the full SHA d2fbdaeView commit details -
Few enhancements and bugfixes in VSFM
- Residual soil mositure can now be specified a non-zero value. - Connection set of a source-sink or boundary condition can be updated. - Correctly initializes auxvars of a boundary condition. - Fixes the update value of boundary condition auxvar.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for af6e0c2 - Browse repository at this point
Copy the full SHA af6e0c2View commit details -
Few fixes after rebasing the branch
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for cb9a3c0 - Browse repository at this point
Copy the full SHA cb9a3c0View commit details -
Multiple fixes to ALM's MPP to enable multiple coupled governing equations.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 9828548 - Browse repository at this point
Copy the full SHA 9828548View commit details -
Removes ALM-MPP dependency on CLM
Adds use_dynamic_linesearch to SoE base type which is set during initialization step. The dependency of SoE base type on clm_varctl is thus removed.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 697c56e - Browse repository at this point
Copy the full SHA 697c56eView commit details -
Fixes for lateral hydrology in VSFM
- Updates the connection_set_type to store type (=horz/vert) for each connection within the connection set. - Fixes mesh setup for lateral connections.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for fa9c921 - Browse repository at this point
Copy the full SHA fa9c921View commit details -
Adds a runtime option to add seepage BC in VSFM
A new runtime option (vsfm_include_seepage_bc) would add seepage face boundary condition to VSFM formulation if lateral flow model in on. This seepage face boundary condition would allow for water to exfiltrate.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for dca1a36 - Browse repository at this point
Copy the full SHA dca1a36View commit details -
Swaps ALM's VSFM code by git submodule
- Deletes existing VSFM code from ACME git. - Adds the VSFM code via git submodule. - Updates ALM's configure script.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 46bf459 - Browse repository at this point
Copy the full SHA 46bf459View commit details -
Removes unused arguments in ALM VSFM solver
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 21cf1f6 - Browse repository at this point
Copy the full SHA 21cf1f6View commit details -
In order to support modifications in VSFM, VSFM initialization by ALM is updated.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 87cda08 - Browse repository at this point
Copy the full SHA 87cda08View commit details -
- Updates the hash of ALM-MPP submodule, and - Minor updates to ALM's initialization of MPP.
Gautam Bisht committedApr 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 018ece7 - Browse repository at this point
Copy the full SHA 018ece7View commit details
Commits on Apr 28, 2017
-
Initial checkin of ALM's External Model Interface
- EMI is used to call external physics formulations in MPP (i.e. VSFM and PTM). - EMI uses the same version of PETSc as used by MPP (i.e. PETSc > 3.7.x)
Gautam Bisht committedApr 28, 2017 Configuration menu - View commit details
-
Copy full SHA for 50d55d0 - Browse repository at this point
Copy the full SHA 50d55d0View commit details
Commits on May 11, 2017
-
Gautam Bisht committed
May 11, 2017 Configuration menu - View commit details
-
Copy full SHA for bb85c7e - Browse repository at this point
Copy the full SHA bb85c7eView commit details -
Removes compilation of deprecated MPP driver
EMI driver for MPP now replaces MPP driver
Gautam Bisht committedMay 11, 2017 Configuration menu - View commit details
-
Copy full SHA for a3c7cbc - Browse repository at this point
Copy the full SHA a3c7cbcView commit details
Commits on May 17, 2017
-
Fixes a build failure with debugging turned on
Gautam Bisht committedMay 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 7b2232d - Browse repository at this point
Copy the full SHA 7b2232dView commit details -
Fixes VSFM for multi-task simulation
- Memory allocation of column-level filters in EMI are now changed such that they are indexed from 1:num_filter instead of begc:endc. - During initialization of VSFM, a new column level filter is used to unpack data from VSFM into ALM's data structure. This is done to avoid overriding column-level data in which VSFM is not active.
Gautam Bisht committedMay 17, 2017 Configuration menu - View commit details
-
Copy full SHA for f941efb - Browse repository at this point
Copy the full SHA f941efbView commit details -
Gautam Bisht committed
May 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 0218221 - Browse repository at this point
Copy the full SHA 0218221View commit details
Commits on May 18, 2017
-
Corrects the column level mesh information needed by PTM
The column level mesh attributes (i.e. soil thickness, soil centroid, and soil layer interface) are needed by PTM for soil and snow layers
Gautam Bisht committedMay 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 2ca6667 - Browse repository at this point
Copy the full SHA 2ca6667View commit details
Commits on May 23, 2017
-
Bug fixes based on global ALM simulation with PTM.
Gautam Bisht committedMay 23, 2017 Configuration menu - View commit details
-
Copy full SHA for bc031d0 - Browse repository at this point
Copy the full SHA bc031d0View commit details
Commits on May 31, 2017
-
Removes output of x,y location of ALM domain
xCell and yCell for the land domain are not set by default. Thus, the output of xCell and yCell resulted in failure when DEBUG is set to TRUE.
Gautam Bisht committedMay 31, 2017 Configuration menu - View commit details
-
Copy full SHA for ed969b2 - Browse repository at this point
Copy the full SHA ed969b2View commit details