Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates land initial conditions for ne120_oRRS18v3 #1514

Merged
merged 1 commit into from
May 15, 2017

Conversation

jqyin
Copy link
Contributor

@jqyin jqyin commented May 10, 2017

Land initial condition for year 1850 at the resolution
ne120_oRRS18v3 is been updated.

Fixes #1492
[NML]
[non-BFB]

@jqyin jqyin added BFB PR leaves answers BFB bug fix PR Land labels May 10, 2017
@jqyin jqyin self-assigned this May 10, 2017
@jqyin jqyin requested a review from bishtgautam May 10, 2017 13:44
@bishtgautam
Copy link
Contributor

This is a NML change instead of a BFB.

@jqyin jqyin added NML non-BFB PR makes roundoff changes to answers. and removed BFB PR leaves answers BFB labels May 10, 2017
jqyin added a commit that referenced this pull request May 11, 2017
Updates land initial conditions for ne120_oRRS18v3

Land initial condition for year 1850 at the resolution
ne120_oRRS18v3 is been updated.

Fixes #1492
[NML]
[non-BFB]
@jqyin
Copy link
Contributor Author

jqyin commented May 11, 2017

Merged to next

Land initial condition for year 1850 at the resolution
ne120_oRRS18v3 is been updated.
@jqyin jqyin force-pushed the jqyin/lnd/update-initial-cond branch from c31cea8 to ff258d9 Compare May 12, 2017 19:01
jqyin added a commit that referenced this pull request May 12, 2017
Updates land initial conditions for ne120_oRRS18v3

Land initial condition for year 1850 at the resolution
ne120_oRRS18v3 is been updated.

Fixes #1492
[NML]
[non-BFB]
@jqyin
Copy link
Contributor Author

jqyin commented May 12, 2017

Re-merged to next to follow new naming convention.

@jqyin jqyin merged commit ff258d9 into master May 15, 2017
jqyin added a commit that referenced this pull request May 15, 2017
Updates land initial conditions for ne120_oRRS18v3

Land initial condition for year 1850 at the resolution
ne120_oRRS18v3 is been updated.

Fixes #1492
[NML]
[non-BFB]
@jqyin
Copy link
Contributor Author

jqyin commented May 15, 2017

Merged #1514

jgfouca pushed a commit that referenced this pull request Jun 2, 2017
Improve error messages for modify_via_xml and cannot_modify_by_user_nl
Test suite: Manual test
Test baseline: N/A
Test namelist changes: N/A
Test status: bit for bit

Fixes #1430

User interface changes?: none

Code review:jedwards
@rljacob rljacob deleted the jqyin/lnd/update-initial-cond branch February 15, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix PR Land NML non-BFB PR makes roundoff changes to answers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants