Fix tmp_array size to avoid array mismatch found by GNU #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I allocated the tmp_array to be too large and GNU compiler stopped with an array mismatch. Change this to be state%ncol in size, not pcol
ndkeen
changed the title
singhbalwinder
approved these changes
May 10, 2017
singhbalwinder
changed the title
singhbalwinder
added a commit
that referenced
this pull request
May 10, 2017
Fixes tmp_array size to avoid array mismatch found by GNU This is a fix to a PR #1501 (github issue #1263). I allocated the tmp_array to be too large and GNU compiler stopped with an array mismatch. Change this to be state%ncol in size, not pcol Fixes #1263 [BFB] * ndk/cam/fix-add-tmp-arrays-use-ncol: This is a fix to a PR #1501 (github issue #1263). I allocated the tmp_array to be too large and GNU compiler stopped with an array mismatch. Change this to be state%ncol in size, not pcol Add a more reasonable pe layout for the a%ne30np4 grid for cori-knl. May not be optimal, but allows for testing.
|
pushed to next |
|
Note, Intel compilers don't catch this. I'm googling and it may be that the language is OK with this and it's a benefit of GNU to note it, but Intel chooses to let it go. We already have |
|
Yes, some compilers allow these kind of assignments. Another point to note is that only tests with |
rljacob
changed the title
singhbalwinder
added a commit
that referenced
this pull request
May 11, 2017
Fixes tmp_array size to avoid array mismatch found by GNU This is a fix to a PR #1501 (github issue #1263). I allocated the tmp_array to be too large and GNU compiler stopped with an array mismatch. Change this to be state%ncol in size, not pcol Fixes #1263 [BFB] * ndk/cam/fix-add-tmp-arrays-use-ncol: This is a fix to a PR #1501 (github issue #1263). I allocated the tmp_array to be too large and GNU compiler stopped with an array mismatch. Change this to be state%ncol in size, not pcol Add a more reasonable pe layout for the a%ne30np4 grid for cori-knl. May not be optimal, but allows for testing.
jgfouca
added a commit
that referenced
this pull request
Jun 2, 2017
define acceptable attributes so that all are not required to be present Define the list of expected attributes to the mpirun command so that the all do not need to be passed in. Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: bit for bit Fixes #1345 User interface changes?: Code review:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the fix for another issue, the tmp_array was allocated to be to large and the GNU compiler stopped with an array mismatch. Reduce the size of the allocated tmp_array by changing the size to be state%ncol, not pcol
This is a redo of PR #1501
Fixes #1263