Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove submodule hacks for jenkins #1569

Merged
merged 2 commits into from
May 31, 2017

Conversation

jgfouca
Copy link
Member

@jgfouca jgfouca commented May 31, 2017

Remove submodule hacks from CIME

With functioning git plugins, jenkins no longer needs these hacks.

[BFB]

Add -f to submodule update.

[BFB]
@jgfouca jgfouca added BFB PR leaves answers BFB CIME labels May 31, 2017
@jgfouca jgfouca self-assigned this May 31, 2017
jgfouca added a commit that referenced this pull request May 31, 2017
…o next (#1569)

Make jenkins submodule handling more robust

Add -f to submodule update.

[BFB]

* jgfouca/cime/make_jenkins_sub_handling_more_robust:
  Make jenkins submodule handling more robust
@bishtgautam
Copy link
Contributor

Just wondering if the repo that jenkins uses to run nightly tests has ACME-Hooks?

@jgfouca
Copy link
Member Author

jgfouca commented May 31, 2017

@bishtgautam it wouldn't matter, there would be authentication problems because Jenkins is using my ssh key to get to the ACME repo and it's doing so through Jenkins.

With functioning git plugins, jenkins no longer needs these hacks.

[BFB]
@jgfouca jgfouca changed the title Make jenkins submodule handling more robust Remove submodule hacks for jenkins May 31, 2017
jgfouca added a commit that referenced this pull request May 31, 2017
…o next (PR #1569)

Merge #2 for this PR.

* jgfouca/cime/make_jenkins_sub_handling_more_robust:
  Remove submodule hacks from CIME
@jgfouca jgfouca merged commit ff14599 into master May 31, 2017
jgfouca added a commit that referenced this pull request May 31, 2017
…o master (PR #1569)

Remove submodule hacks from CIME

With functioning git plugins, jenkins no longer needs these hacks.

[BFB]

* jgfouca/cime/make_jenkins_sub_handling_more_robust:
  Remove submodule hacks from CIME
@jgfouca jgfouca deleted the jgfouca/cime/make_jenkins_sub_handling_more_robust branch May 31, 2017 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB CIME
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants