Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes conflict between next and master after PR1693 merge #1751

Merged
merged 2 commits into from
Aug 25, 2017

Conversation

AaronDonahue
Copy link
Contributor

[BFB] - Bit-For-Bit

@AaronDonahue AaronDonahue added the BFB PR leaves answers BFB label Aug 25, 2017
@rljacob rljacob assigned rljacob and jgfouca and unassigned rljacob Aug 25, 2017
@rljacob
Copy link
Member

rljacob commented Aug 25, 2017

What happened here? This is not how we usually fix this.

@AaronDonahue
Copy link
Contributor Author

AaronDonahue commented Aug 25, 2017

@rljacob , I made an error in fixing the conflicts with PR#1693 which led to conflicts between next and master. @jgfouca brought it my attention on Slack through the se_cpl-group channel and suggested that the best way to remedy the issue would be though a new PR. I am also happy to revert my merge if that is the correct way to do things. This is my first time dealing with a conflict in merging.

Let me know what is the best course of action and I'll go ahead and do that.

@rljacob
Copy link
Member

rljacob commented Aug 25, 2017

I think this should only be merged to master. I get conflicts if I try to merge it to next.

@AaronDonahue
Copy link
Contributor Author

Ok, should I go ahead and do that now?

@rljacob
Copy link
Member

rljacob commented Aug 25, 2017

No there are some whitespace diffs in components/clm/bld/namelist_files/namelist_defaults_clm4_5.xml that still need to be fixed.

@AaronDonahue
Copy link
Contributor Author

I think that fixed it, I tested by locally attempting a merge with next and did not get any conflicts.

@rljacob
Copy link
Member

rljacob commented Aug 25, 2017

Yes I think that did it.

@AaronDonahue
Copy link
Contributor Author

Excellent, I'll merge to master now.

@AaronDonahue AaronDonahue merged commit 440046c into master Aug 25, 2017
@AaronDonahue AaronDonahue deleted the aarondonahue/atm/fixmerge_pr1693 branch August 25, 2017 04:16
jgfouca pushed a commit that referenced this pull request Sep 15, 2017
remove untested/unused scripts in Tools directory
These scripts in the Tools directory appear to be unused and are untested.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

Code review:mvertens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants