Add mach-specific throughput checking to test machines #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfouca
approved these changes
Sep 7, 2017
|
@amametjanov this looks good. Just so you know, we do NOT report throughput regressions on the dashboard (it was way too noisy), so this change won't impact anything on the dashboard. |
|
Can we enable throughput regressions in the same category as namelist comparisons? This way they can be ignored (not a red flag), but at the same time help with performance monitoring. |
|
I'll add this to the wish list: https://acme-climate.atlassian.net/wiki/spaces/SE/pages/62095556/ACME+Test+System+wish+list |
|
@amametjanov that's a good idea |
jgfouca
added a commit
that referenced
this pull request
Sep 12, 2017
Add mach-specific throughput checking to test machines Throughput comparison was previously done at 25% tolerance/deviation from baseline. This PR adds machine-specific throughput tolerance of 10% for all test machines. This should enable detection of performance regression of greater than 10% on machines and tests that have baselines (e.g. melvin, skybridge, chama). [BFB] * origin/azamat/tests/check-tput: Add mach-specific throughput checking to test machines
jgfouca
added a commit
that referenced
this pull request
Sep 12, 2017
Add mach-specific throughput checking to test machines Throughput comparison was previously done at 25% tolerance/deviation from baseline. This PR adds machine-specific throughput tolerance of 10% for all test machines. This should enable detection of performance regression of greater than 10% on machines and tests that have baselines (e.g. melvin, skybridge, chama). [BFB] * origin/azamat/tests/check-tput: Add mach-specific throughput checking to test machines
jgfouca
pushed a commit
that referenced
this pull request
Sep 15, 2017
Allow --compiler and --mpilib in ctest scripts This PR allows ctest to use the new --compiler and --mpilib options in scripts_regression_tests.py by using env variables CIME_COMPILER and CIME_MPILIB Test suite: CIME_COMPILER=nag ./cime.ctest.hobart Test baseline: Test namelist changes: Test status: bit for bit Fixes #1770 User interface changes?: Update gh-pages html (Y/N)?: Code review: Bill Sacks
jgfouca
added a commit
that referenced
this pull request
Oct 25, 2017
Add mach-specific throughput checking to test machines Throughput comparison was previously done at 25% tolerance/deviation from baseline. This PR adds machine-specific throughput tolerance of 10% for all test machines. This should enable detection of performance regression of greater than 10% on machines and tests that have baselines (e.g. melvin, skybridge, chama). [BFB] * origin/azamat/tests/check-tput: Add mach-specific throughput checking to test machines
jgfouca
added a commit
that referenced
this pull request
Feb 27, 2018
Add mach-specific throughput checking to test machines Throughput comparison was previously done at 25% tolerance/deviation from baseline. This PR adds machine-specific throughput tolerance of 10% for all test machines. This should enable detection of performance regression of greater than 10% on machines and tests that have baselines (e.g. melvin, skybridge, chama). [BFB] * origin/azamat/tests/check-tput: Add mach-specific throughput checking to test machines
jgfouca
added a commit
that referenced
this pull request
Mar 14, 2018
Add mach-specific throughput checking to test machines Throughput comparison was previously done at 25% tolerance/deviation from baseline. This PR adds machine-specific throughput tolerance of 10% for all test machines. This should enable detection of performance regression of greater than 10% on machines and tests that have baselines (e.g. melvin, skybridge, chama). [BFB] * origin/azamat/tests/check-tput: Add mach-specific throughput checking to test machines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throughput comparison was previously done at 25% tolerance/deviation from baseline. This PR adds machine-specific throughput tolerance of 10% for all test machines. This should enable detection of performance regression of greater than 10% on machines and tests that have baselines (e.g. melvin, skybridge, chama).
[BFB]