Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds machine files for Compy #2854

Merged
merged 4 commits into from
Apr 17, 2019
Merged

Conversation

singhbalwinder
Copy link
Contributor

This PR adds first set of machine files for E3SM machine Compy. Machine
files for compilers Intel, gnu and PGI are added. I have used the
following test to compile and run the model:

SMS.ne4_ne4.FC5AV1C-L

For the above test:
-Intel compiler works fine
-GNU 4.8.5: Land model has a compile time error
-PGI: Netcdf is not built using this compiler yet

[BFB]

Copy link
Member

@rljacob rljacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the gnu version to 7.3 which is what we test on melvin.

@rljacob
Copy link
Member

rljacob commented Apr 15, 2019

You could just remove the gnu entry and continue with this PR. Then add 7.3 when its ready.

@rljacob rljacob assigned bibiraju and unassigned jgfouca Apr 15, 2019
This PR adds first set of machine files for E3SM machine Compy. Machine
files for compilers Intel, gnu and PGI are added. I have used the
following test to compile and run the model:

SMS.ne4_ne4.FC5AV1C-L

For the above test:
-Intel compiler works fine
-GNU 4.8.5: Land model has a compile time error
-PGI: Netcdf is not built with this compiler yet

[BFB]
gnu compiler builds fine but blows up during run time with
following error:

set_time_float_from_date: error return from ESMF_TimeSet
for set_time_float_from_date
ERROR: CHKRC

[BFB] - Bit-For-Bit
@singhbalwinder singhbalwinder force-pushed the singhbalwinder/cime/compy-mach-files branch from 32659f1 to 68ef274 Compare April 15, 2019 21:23
@singhbalwinder
Copy link
Contributor Author

@rljacob : PGI (18.10) and Intel now works fine. MKL library paths have been moved around which I have fixed in the machine files. I have also simplified the machine files a bit. With GNU (8.1.0) compiler, I am getting a run time error (model builds fine):

set_time_float_from_date: error return from ESMF_TimeSet for set_time_float_from_date
 ERROR: CHKRC

I do not know how to resolve this error.

PGI compiler reported a compile time error due to missing isnan use statement in one of the land model's file (components/clm/src/data_types/VegetationDataType.F90). I have fixed that and I will issue a separate PR for that fix.

@minxu74
Copy link
Contributor

minxu74 commented Apr 16, 2019

@singhbalwinder Could you try to build the test SMS.T62_oQU120_ais20.MPAS_LISIO_TEST on Compy with PGI? I got a build error with PGI on Summit (#2862 ) and want to see if the same error happened on Compy. Thanks.

@singhbalwinder
Copy link
Contributor Author

@minxu74 : I tried this test case but it blew up during setup due to lack of partition files. I think it is most likely due to the default PE layout the model is picking up. I do not know enough about MPAS model to figure out a PE layout which will ask for a "right" PE layout so that the existing files are downloaded automatically from the server.

@minxu74
Copy link
Contributor

minxu74 commented Apr 16, 2019

@singhbalwinder Thanks. I do not know if you can set the PE layout of the test as the one on Summit. It sets the NTASKS to 64 except for ESP and NTHRDS to 1. The files needed by MPAS for that PE layout should be in the E3SM input directory or LCRC public web server.

@singhbalwinder
Copy link
Contributor Author

@minxu74 : It is using 64 tasks on Compy as well. Right now, I got a build error possibly due to lack on PNETCDF. I have asked the support to install PNETCDF. I will see if I can move forward after they install it.

@rljacob
Copy link
Member

rljacob commented Apr 17, 2019

@minxu74 the priority now is just get Compy working. Diagnosing pgi problems from other machines can wait.

@minxu74
Copy link
Contributor

minxu74 commented Apr 17, 2019

@singhbalwinder @rljacob Sorry, please go ahead and focus on the PR. Thanks

[BFB] - Bit-For-Bit
@singhbalwinder
Copy link
Contributor Author

@rljacob : I have run few more simulations and everything looks fine with Intel and PGI compilers. MPAS test works with intel but the Lustre drive crashed while I was doing the PGI test. Tim Carlson is currently working on fixing that.

GNU compiler has a run time error which seems related to some timing/calendar issue. I am not sure how to fix that. Should we merge this PR as is or do you think we should remove machine files for GNU and then merge it?

@rljacob
Copy link
Member

rljacob commented Apr 17, 2019

Remove the gnu entry, update the branch and then merge.

@singhbalwinder
Copy link
Contributor Author

I have removed GNU from the machine files.

@rljacob
Copy link
Member

rljacob commented Apr 17, 2019

The keep things simple, lets just focus on the Intel compiler. Once that is working, more people can get on and do work.

@rljacob
Copy link
Member

rljacob commented Apr 17, 2019

Leave PGI in, but don't worry if things aren't building/passing with it.

@singhbalwinder
Copy link
Contributor Author

Ok, Intel is working fine with FC5AV1C-L with both ne4 and ne30. It also worked fine for the MPAS_LISIO_TEST compset with T62_oQU120_ais20 grid. I also ran a long 6 year simulation with ne30, F compset and it ran fine. So, I think, this PR is ready to merge once next and master are open to accept new PRs.

@rljacob
Copy link
Member

rljacob commented Apr 17, 2019

Since this is machine-specific, you can go ahead and merge to next and master.

@singhbalwinder
Copy link
Contributor Author

Thanks @rljacob ! I think it needs your approval before @bibiraju can merge it.

bibiraju added a commit that referenced this pull request Apr 17, 2019
Add machine files for Compy

This PR adds first set of machine files for E3SM machine Compy. Machine
files for compilers Intel, gnu and PGI are added. I have used the
following test to compile and run the model:

SMS.ne4_ne4.FC5AV1C-L

For the above test:
-Intel compiler works fine
-GNU 4.8.5: Land model has a compile time error
-PGI: Netcdf is not built using this compiler yet

[BFB]
@bibiraju bibiraju merged commit cb9b02d into master Apr 17, 2019
bibiraju added a commit that referenced this pull request Apr 17, 2019
Adds machine files for Compy

This PR adds first set of machine files for E3SM machine Compy. Machine
files for compilers Intel, gnu and PGI are added. I have used the
following test to compile and run the model:

SMS.ne4_ne4.FC5AV1C-L

For the above test:
-Intel compiler works fine
-GNU 4.8.5: Land model has a compile time error
-PGI: Netcdf is not built using this compiler yet

[BFB]
@singhbalwinder singhbalwinder deleted the singhbalwinder/cime/compy-mach-files branch April 29, 2019 22:37
@rljacob rljacob added the Compy label Jun 25, 2019
jgfouca pushed a commit that referenced this pull request Jun 25, 2019
Adds machine files for Compy

This PR adds first set of machine files for E3SM machine Compy. Machine
files for compilers Intel, gnu and PGI are added. I have used the
following test to compile and run the model:

SMS.ne4_ne4.FC5AV1C-L

For the above test:
-Intel compiler works fine
-GNU 4.8.5: Land model has a compile time error
-PGI: Netcdf is not built using this compiler yet

[BFB]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB Compy Machine Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants