Add interface variables to nc output in standalone homme #3078

oksanaguba · 2019-07-18T23:35:42Z

Adds native and interpolated output of interface quantities in homme, in particular, for w and mu (dpnh/dphy). Fixes std output for interface quantities to have min/max calculated on interfaces, not averaged level values.

[bfb], affects only standalone homme.

oksanaguba · 2019-07-18T23:39:59Z

sanity check -- from plotting both wnlev and wnlevp they look the same (up to the bottom point).

…iting(?) phi and theta.

…e/w-movie

…uba/homme/w-movie" This reverts commit 3a1ae7d, reversing changes made to 5296dbe.

…it guess)

This reverts commit 50ffcda.

…modif init guess)" This reverts commit 1e85d41.

oksanaguba · 2019-09-12T20:40:07Z

I ran ne30 HS test for 10 days and looked at both interp (ncview) and native (ncl) output for geo_i, w_i, mu_i . I see nothing alarming. @mt5555 do you have more suggestions about this code? I will run homme suite with it.

oksanaguba · 2019-09-18T03:48:52Z

By some reason baroCamMoistSL ran on anvil without issues in this branch and commit it branched off.

oksanaguba · 2019-09-21T22:18:09Z

SW tests were fixed, this is ready.

oksanaguba · 2019-09-21T23:18:34Z

Reran previous interp and native output with the newest commit and files are identical (folder /home/onguba/as/run-test-wmovie-pr/movies ).

mt5555 · 2019-09-21T22:26:06Z

components/homme/src/interp_movie_mod.F90

+    call nf_variable_attributes(ncdf, 'mu_i', 'mu=dp/d\pi on interfaces','dimensionless')
+    call nf_variable_attributes(ncdf, 'geo_i','geopotential on interfaces','meters')
+    call nf_variable_attributes(ncdf, 'pnh',  'total pressure','Pa')
+#endif


can you remove all the #ifdef MODEL_THETA_L's from this file? One of the reasons behind the "get_field()" interface was so we wouldn't need ifdef's. The preqx model will abort if someone requests a variable that is not supported, like w_i.

so lets also add the get_field_i() routine to preqx.

mt5555 · 2019-09-21T22:28:15Z

components/homme/src/prim_movie_mod.F90

@@ -188,6 +191,7 @@ subroutine prim_movie_init(elem, par, hvcoord,tl)
         compDOF(1:1),IOdescT)

    deallocate(compdof)
+    deallocate(compdofp1)


note how the 2d and 3D arrays are both using compdof. can we do the same here and bump up the dimension of compdof and you dont need to introduce compdofp1?

mt5555 · 2019-09-21T22:29:06Z

components/homme/src/prim_movie_mod.F90

+    call nf_variable_attributes(ncdf, 'mu_i', 'mu=dp/d\pi on interfaces','dimensionless')
+    call nf_variable_attributes(ncdf, 'geo_i','geopotential on interfaces','meters')
+    call nf_variable_attributes(ncdf, 'pnh',  'total pressure','Pa')
+#endif


per previous comment - can we avoid all #ifdef MODEL_THETA_L in this file

mt5555 · 2019-09-21T22:32:06Z

components/homme/src/share/prim_driver_base.F90

+       elem(ie)%derived%mubottom(:,:)=1.0
+    enddo
+#endif
+


this is getting complicated - I think if you really need mu at the surface we need to introduce a subroutine to compute it and it should be called by the I/O and by prim_advance_mod.F90

mt5555 · 2019-09-21T22:33:37Z

components/homme/src/theta-l/element_ops.F90

+      field = elem%state%phinh_i(:,:,1:nlevp,nt)
+    case('mu');
+      call get_dpnh_dp_i(elem,field,hvcoord,nt)
+    case default


shouldn't the names be "w_i", since someone may ask for "w" on midpoints and "w_i" on interfaces?
there are existing NCL scripts that will break if 'w' and 'geo' output is now at interfaces instead of midpoints.

Will do. I removed w from interp_output but i will put it back. geo and geo_i are already there.

mt5555 · 2019-09-21T22:34:41Z

components/homme/src/theta-l/element_ops.F90

+  call pnh_and_exner_from_eos(hvcoord,elem%state%vtheta_dp(:,:,:,nt),&
+       dp,elem%state%phinh_i(:,:,:,nt),pnh,exner,dpnh_dp_i)
+
+  dpnh_dp_i(:,:,nlevp) = elem%derived%mubottom(:,:) 


see comment above - i think this is too difficult to maintain

mt5555 · 2019-09-21T22:44:05Z

components/homme/src/theta-l/element_state.F90

@@ -80,6 +79,8 @@ module element_state
    real (kind=real_kind) :: FQps(np,np)                   ! forcing of FQ on ps_v

    real (kind=real_kind) :: gradphis(np,np,2)   ! grad phi at the surface, computed once in model initialization
+
+    real (kind=real_kind) :: mubottom(np,np)                       !mu


another problem with this approach: mu will be at the wrong time level.

why? mubottom is obtained in caar and not changed in dirk, or by remap. or does it get changed by remap?

oksanaguba · 2019-09-29T04:07:37Z

Homme suite is ok, it is ready to be reviewed again @mt5555 .

oksanaguba · 2019-10-01T21:55:39Z

Assigning to myself since it was approved, unless there are objections.

rljacob · 2019-10-10T17:40:14Z

@oksanaguba please merge this.

Adds native and interpolated output of interface quantities in homme, in particular, for w and mu (dpnh/dphy). Fixes std output for interface quantities to have min/max calculated on interfaces, not averaged level values. [bfb], affects only standalone homme.

oksanaguba · 2019-10-11T18:09:32Z

Merged to next.

Adds native and interpolated output of interface quantities in homme, in particular, for w and mu (dpnh/dphy). Fixes std output for interface quantities to have min/max calculated on interfaces, not averaged level values. [bfb], affects only standalone homme.

When using pio2 if the pio_numiotasks and pio_stride indicate processors above the model task count you will get an error. This change prevents that happening. Test suite: by hand SMS_P45.f19_g16.X Test baseline: Test namelist changes: Test status: bit for bit Fixes User interface changes?: Update gh-pages html (Y/N)?: Code review:

…_L128_REP EAMxx: Add an REP L128 test.

mt5555 and others added 2 commits July 17, 2019 22:43

add theta-l config for dcmip2012 2.1 and 2.2 tests

aa7da45

start on w nlevp output

531d1cc

fix name for dcmip 2.2 test script

6ea3567

rljacob added the HOMME label Jul 19, 2019

oksanaguba added 2 commits July 20, 2019 20:30

intermediate commit used for rsplit0 profiles

dd77187

fixing nlevp output for native grid and netcdf

7a1e3f3

rljacob assigned mt5555 Jul 24, 2019

mt5555 added HOMME standalone issues with the standalone HOMME code that dont impact E3SM and removed HOMME labels Jul 24, 2019

oksanaguba added 20 commits July 24, 2019 20:17

print location of maxerror

07435c9

add mu, all geo

60a1e42

printstatements for iterations etc

00fdbc9

more output options

a629e63

commit that does not run from the same restart, code somewhere overwr…

8b21f24

…iting(?) phi and theta.

cleaned up output of mu and stuff

a7bdeb7

more printstatements

021d5c8

bugfix in mu, repeated code to clean later

b1d432b

start on latlon output

5296dbe

Merge remote-tracking branch 'MT/dcmip2-theta-l' into oksanaguba/homm…

3a1ae7d

…e/w-movie

wip interp output

44b4721

interp output with debug staetments

a4d31b3

clean up

b52b00d

Revert "Merge remote-tracking branch 'MT/dcmip2-theta-l' into oksanag…

beab81c

…uba/homme/w-movie" This reverts commit 3a1ae7d, reversing changes made to 5296dbe.

init guess based on mu=1, output for imex results based on guess

44bde1a

debug code, old dirk works bfb with new dirk with guess0 (no modif in…

1e85d41

…it guess)

mode debug code

50ffcda

put bowman cmake file in here

768cd22

Revert "mode debug code"

b260c9f

This reverts commit 50ffcda.

Revert "debug code, old dirk works bfb with new dirk with guess0 (no …

130b3a5

…modif init guess)" This reverts commit 1e85d41.

oksanaguba added 4 commits September 11, 2019 15:40

add pnh to native output, minor changes

ea9b0a8

reverting _advance mod to commit at branching

0951080

reverting eos mod to commit at branching

c3f12f3

cleaning unused vars, minor changes

c16fb51

oksanaguba changed the title ~~[wip] w on interfaces in homme movies~~ Adds interface quantities to nc output in standalone homme Sep 12, 2019

oksanaguba changed the title ~~Adds interface quantities to nc output in standalone homme~~ Add interface quantities to nc output in standalone homme Sep 13, 2019

fixing preqx build, all tests pass except for SW

28f3c30

fixing SW builds

5c31771

oksanaguba changed the title ~~Add interface quantities to nc output in standalone homme~~ Add interface variables to nc output in standalone homme Sep 21, 2019

oksanaguba added the BFB PR leaves answers BFB label Sep 21, 2019

mt5555 requested changes Sep 21, 2019

View reviewed changes

oksanaguba added 2 commits September 28, 2019 20:17

requested fixes (not yet working)

80a7119

bugfixes, homme tests pass

157b397

mt5555 approved these changes Sep 30, 2019

View reviewed changes

oksanaguba assigned oksanaguba and unassigned mt5555 Oct 1, 2019

oksanaguba merged commit 157b397 into master Oct 14, 2019

oksanaguba deleted the oksanaguba/homme/w-movie branch October 14, 2019 15:58

jgfouca pushed a commit that referenced this pull request Nov 7, 2024

Merge pull request #3078 from E3SM-Project/ambrad/test-e3sm_scream_v1…

62a2778

…_L128_REP EAMxx: Add an REP L128 test.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add interface variables to nc output in standalone homme #3078

Add interface variables to nc output in standalone homme #3078

oksanaguba commented Jul 18, 2019 •

edited

Loading

oksanaguba commented Jul 18, 2019

oksanaguba commented Sep 12, 2019 •

edited

Loading

oksanaguba commented Sep 18, 2019

oksanaguba commented Sep 21, 2019

oksanaguba commented Sep 21, 2019

mt5555 Sep 21, 2019

mt5555 Sep 21, 2019

mt5555 Sep 21, 2019

mt5555 Sep 21, 2019

mt5555 Sep 21, 2019

oksanaguba Sep 22, 2019

mt5555 Sep 21, 2019

mt5555 Sep 21, 2019

oksanaguba Sep 22, 2019

oksanaguba commented Sep 29, 2019

oksanaguba commented Oct 1, 2019

rljacob commented Oct 10, 2019

oksanaguba commented Oct 11, 2019

Add interface variables to nc output in standalone homme #3078

Add interface variables to nc output in standalone homme #3078

Conversation

oksanaguba commented Jul 18, 2019 • edited Loading

oksanaguba commented Jul 18, 2019

oksanaguba commented Sep 12, 2019 • edited Loading

oksanaguba commented Sep 18, 2019

oksanaguba commented Sep 21, 2019

oksanaguba commented Sep 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oksanaguba commented Sep 29, 2019

oksanaguba commented Oct 1, 2019

rljacob commented Oct 10, 2019

oksanaguba commented Oct 11, 2019

oksanaguba commented Jul 18, 2019 •

edited

Loading

oksanaguba commented Sep 12, 2019 •

edited

Loading