Fix compiler error when fv_nphys=0 #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When GNU is used in debug mode on certain machines it will complain if fv_nphys=0 even thought those blocks of code are never used. This fixes the issue by using a dummy variable to hold the product of fv_nphys*fv_nphys. modified: components/cam/src/dynamics/se/dyn_grid.F90
AaronDonahue
approved these changes
Aug 15, 2019
|
The comment in the code you replaced says "Note: the max() is to fool the compiler debug mode when fv_nphys=0". Did the max no longer work? |
|
@AaronDonahue, that is the correct behavior. We're only interested in the block/element, which always has nphys_sq FV cells. @rljacob, the max would still have worked, but I figure the new way was more sensible and made the code a bit cleaner. |
rljacob
added a commit
that referenced
this pull request
Aug 16, 2019
When building with GNU in debug mode on certain machines it will complain if fv_nphys=0 even though those blocks of code are never used. This fixes the issue by using a dummy variable to hold the product of fv_nphys*fv_nphys. [BFB] * whannah/atm/fix-pg-compiler-bug: Fix compiler error when fv_nphys=0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with GNU in debug mode on certain machines it will complain
if fv_nphys=0 even though those blocks of code are never used. This
fixes the issue by using a dummy variable to hold the product of
fv_nphys*fv_nphys.
[BFB]