create_test: Fix race condition with PEND state in TestStatus #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the PEND state addition from testcase_setup to create_test_impl. This will ensure it gets created before wait_for_tests is run. [BFB]
|
Taking advantage of Jeff still being here and assigning to him. |
jeff-cohere
pushed a commit
that referenced
this pull request
Oct 21, 2015
…nto next (PR #380) create_test: Fix race condition with PEND state in TestStatus Move the PEND state addition from testcase_setup to create_test_impl. This will ensure it gets created before wait_for_tests is run. [BFB]
|
Shall we send this through a testing cycle on next before merging to master, since it affects the creation of testing machinery? |
|
Probably just merge to master. Sooner the better. The current next branch results aren't useful without this. |
|
Skipping integration testing. |
jeff-cohere
pushed a commit
that referenced
this pull request
Oct 21, 2015
#380) create_test: Fix race condition with PEND state in TestStatus Move the PEND state addition from testcase_setup to create_test_impl. This will ensure it gets created before wait_for_tests is run. [BFB]
jeff-cohere
deleted the
jgfouca/scripts-acme/fix_another_race_in_test_status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the PEND state addition from testcase_setup to create_test_impl.
This will ensure it gets created before wait_for_tests is run.
[BFB]