Including the Fortran C interface cmake module before using it #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Fortran C interface cmake module needs to be included before using functions in the module. Without the fix a cmake build of the timing util will fail. [B4B]
|
This change should not affect existing ACME builds (The current build system does not perform a cmake build of the timing util library). This change is required for an upcoming PIO fix. |
|
Although this is part of the build script its also in the util/timing directory so alerting @worleyph. |
|
I've been waiting for this check-in (thanks Jayesh), and have already |
|
Just did a quick test on redsky, no adverse effects. merged. |
jayeshkrishna
deleted the
jayeshkrishna/utils_timing/bugfix_cmake_build
branch
rljacob
added a commit
that referenced
this pull request
Apr 25, 2017
Remove trailing whitespace from all files. [BFB]
wagmanbe
pushed a commit
to wagmanbe/E3SM
that referenced
this pull request
Apr 20, 2023
…ect#45) Update .gitmodules for submodules added in a previous PR Two submodules were added in PR E3SM-Project#43 improperly, causing fatal error on git submodule update. [BFB]
jonbob
pushed a commit
that referenced
this pull request
Oct 27, 2023
Move comments to Registry and update bld files to match
sbrus89
pushed a commit
to sbrus89/E3SM
that referenced
this pull request
Jan 19, 2024
* Adds memory cleanup functions for some Omega classes For Omega classes that store all instances, this adds some erase/clear functions to clean up memory before the yakl finalize call. Updates developer guide to note the requirement for this cleanup.
sbrus89
pushed a commit
to sbrus89/E3SM
that referenced
this pull request
Jan 22, 2024
* Adds memory cleanup functions for some Omega classes For Omega classes that store all instances, this adds some erase/clear functions to clean up memory before the yakl finalize call. Updates developer guide to note the requirement for this cleanup.
sbrus89
pushed a commit
to sbrus89/E3SM
that referenced
this pull request
Jan 26, 2024
* Adds memory cleanup functions for some Omega classes For Omega classes that store all instances, this adds some erase/clear functions to clean up memory before the yakl finalize call. Updates developer guide to note the requirement for this cleanup.
GeorginaGibson
pushed a commit
to GeorginaGibson/E3SM
that referenced
this pull request
Aug 29, 2024
Port to Carpenter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fortran C interface cmake module needs to be included before
using functions in the module. Without the fix a cmake build of
the timing util will fail.
[B4B]