Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit Visbeck eddy length to dcEdge (AMOC PR 4/6) #4868

Merged
merged 2 commits into from
Apr 14, 2022
Merged

limit Visbeck eddy length to dcEdge (AMOC PR 4/6) #4868

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64ad3f3
limit Visbeck eddy length to dcEdge
mark-petersen Apr 4, 2022
0869d61
change eddyLength & eddyTime to scalars
mark-petersen Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/mpas-ocean/src/shared/mpas_ocn_gm.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,8 +611,8 @@ subroutine ocn_GM_compute_Bolus_velocity(statePool, &
c_Visbeck = sqrt(sumN2*ltsum)
sumRi = sumRi / (ltsum + 1.0E-11_RKIND)

eddyLength(iEdge) = min(c_Visbeck/(1.0E-15_RKIND + abs(fEdge(iEdge))), &
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanroekel this array was created in the original Visbeck addition. Both eddyLength and eddyTime are used only in these three lines within the iEdge loop, so these arrays could both easily be replaced by scalars. The only reason to keep them is for writing them out. Do you have a preference if these are arrays or scalars?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-petersen no real preference on scalar v array. I had them as arrays for diagnostics but I don't think we need them for the duration.

sqrt(c_Visbeck/ (2.0_RKIND*betaEdge(iEdge))))
eddyLength(iEdge) = max(dcEdge(iEdge), min(c_Visbeck/(1.0E-15_RKIND + abs(fEdge(iEdge))), &
sqrt(c_Visbeck/ (2.0_RKIND*betaEdge(iEdge)))))
eddyTime(iEdge) = 1.0_RKIND / (max(abs(fEdge(iEdge)), sqrt(2.0_RKIND*c_Visbeck*betaEdge(iEdge))) / &
(1.0E-11_RKIND + sqrt(sumRi)))
gmBolusKappa(iEdge) = config_GM_Visbeck_alpha * eddyLength(iEdge)**2.0_RKIND / (1.0E-15 + eddyTime(iEdge))
Expand Down