Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change a reproducible sum algorithm in SI solver #4898

Merged
merged 1 commit into from
May 9, 2022

Conversation

hyungyukang
Copy link
Contributor

@hyungyukang hyungyukang commented Apr 20, 2022

Change a reproducible sum algorithm in the ocean split-implicit barotropic mode solver. The changed algorithm uses a global reproducible summation module in components/mpas-framework/src/framework/mpas_global_sum_mod.F

This PR passed PEM_Ln9_D.T62_oQU240.GMPAS-IAF.cori-knl_gnu test with config_time_integrator = 'split_implicit' and config_btr_si_partition_match_mode = .true..

[BFB]

Change a reproducible sum algorithm in the ocean split-implicit solver. The changed algorithm uses a global reproducible summation module in components/mpas-framework/src/framework/mpas_global_sum_mod.F
@hyungyukang hyungyukang self-assigned this Apr 20, 2022
@hyungyukang hyungyukang added BFB PR leaves answers BFB mpas-ocean labels Apr 20, 2022
Copy link
Contributor

@philipwjones philipwjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve based on code inspection and the previous successful PEM test that shows the sums themselves are reproducible across node configurations. Note that the branch naming convention uses hyphens and not underscores.

The new algorithm is not likely to give a bfb result compared to the old, so I'm guessing the bfb flag here is because this option is off by default?

@hyungyukang
Copy link
Contributor Author

Approve based on code inspection and the previous successful PEM test that shows the sums themselves are reproducible across node configurations. Note that the branch naming convention uses hyphens and not underscores.

The new algorithm is not likely to give a bfb result compared to the old, so I'm guessing the bfb flag here is because this option is off by default?

@philipwjones , thanks for reviewing and approving this PR. Exactly. The config_btr_si_partition_match_mode is turned off by default, so the SI solver with default options is exactly the same with a previous version.

@jonbob jonbob added the Stealth PR has feature which, if turned on, could change climate. fka FCC label May 5, 2022
jonbob added a commit that referenced this pull request May 6, 2022
Change a reproducible sum algorithm in SI solver

Change a reproducible sum algorithm in the ocean split-implicit
barotropic mode solver. The changed algorithm uses a global reproducible
summation module in
components/mpas-framework/src/framework/mpas_global_sum_mod.F. This
option is off by default.

[BFB]
@jonbob
Copy link
Contributor

jonbob commented May 6, 2022

Test merge passes:

  • ERS.ne11_oQU240.WCYCL1850NS.chrysalis_intel
  • SMS_P12x2.ne4_oQU240.WCYCL1850NS.chrysalis_intel.allactive-mach_mods
  • SMS_D_Ld3.T62_oQU120.CMPASO-IAF.chrysalis_intel

merged to next

@jonbob jonbob merged commit 5322849 into master May 9, 2022
@jonbob
Copy link
Contributor

jonbob commented May 9, 2022

merged to master

@jonbob jonbob deleted the hkang/ocean/si_bfbsum branch May 9, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-ocean Stealth PR has feature which, if turned on, could change climate. fka FCC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants