Differentiate input and input/output streams in MPAS stream manager #4929
Conversation
…reams Previously, the mpas_stream_mgr_read() routine ignored the difference between streams of direction INPUT and direction INPUT_OUTPUT (i.e. restart streams). However, there are situation where it would be desirable to read only truly direction INPUT streams. One example is at the initial time of a coldstart run - one wants to read any input streams without reading the restart stream (which does not exist yet). This commit adds an optional argument to force mpas_stream_mgr_read to ignore INPUT_OUTPUT streams and only read truly INPUT streams. Its default value maintains the previous behavior.
This commit removes the restriction that the initial condition stream have the name 'input' and now allows any streams of direction input that have input_interval='initial_only' to be read at the initial time. This allows an initial condition to be spread across multiple files. It also prevents an obscure error that was causing streams of input_interval='initial_only' to be read on the initial time of a restart. With this change, 'initial_only' truly means the initial time of a simulation, regardless of restarting it or not. This commit also adds some missing timer calls.
matthewhoffman
added
mpas-albany-landice
minor
BFB
|
Discussed and tested for standalone MALI usage in the MALI-Dev fork of E3SM here: MALI-Dev#35 I've moved the PR here because it changes MPAS framework. I could move the MALI changes into a separate PR, but I don't see a problem with including it here. If we keep MALI changes here, I would close MALI-Dev#35 |
|
@xylar , @mark-petersen , @akturner , I looked into the issues with On contrast, the relevant bit of of code in MPAS-Ocean is the read on init here: So the new optional argument I introduced in this PR tells |
|
@matthewhoffman, thanks for the clarification. I'll do some standalone testing in compass. @jonbob, do you have a suggestion for what the most relevant test in E3SM would be to make sure restarting is unaffected in both ocean and sea ice? I'm happy to run such a test if it's not already part of your testing. |
|
@xylar -- this one is good for both seaice and ocean: But it is one of the tests I almost always run to test a merge |
|
I am running compass tests on this right now. I tried the E3SM tests but ran into ESMCI/cime#4251. I will try with a clone of E3SM outside of compass. |
|
I did a test merge of this PR with the latest E3SM-Project submodule in compass (E3SM/master from 4 days ago). Then, I ran the ocean PR test suite from compass in debug and optimized mode for the 5 compiler/MPI configurations we have on Anvil. All passed and were bit-for-bit with the baseline I created when the submodule in compass got updated. I ran |
|
@matthewhoffman - not a big deal this time, but the branch naming convention is to use hyphens and not underscores... |
#4929) Differentiate input and input/output streams in MPAS stream manager This PR improves the MPAS Stream Manager by introducing an optional argument to differentiate between streams of direction INPUT and direction INPUT_OUTPUT. Previously, the mpas_stream_mgr_read() routine ignored the difference between streams of direction INPUT and direction INPUT_OUTPUT (i.e. restart streams). However, there are situation where it would be desirable to read only truly direction INPUT streams. One example is at the initial time of a coldstart run - one would typically want to read any input streams without reading the restart stream (which does not exist yet). This PR adds an optional argument to force mpas_stream_mgr_read to ignore INPUT_OUTPUT streams and only read truly INPUT streams. Its default value maintains the previous behavior. A second commit modifies the MALI driver to make use of this new capability to improve and simplify the input stream handling at the initial time of a MALI simulation. [BFB]
|
test merge passes:
merged to next |
|
merged to master |
This is desired to get E3SM-Project#4929 and updates for compiling on Cori. * e3sm/master: (288 commits) Add a fix for restarts generated before the final time step Fixes CIME import paths in template files Homme genf90 fix Add back custom mpaso and elm PEs for Mappy Add minor CIME fix for configure tool CIME update Added fsurdat for simyr2010 on ne120np4 Add cime update to set component-specific PES_SPEC_FILE Simplify & generalize MALI stream read behavior at initial time Allow mpas_stream_mgr_read() to read only strictly INPUT direction streams Split config_pesall into component-specific config_pes run_e3sm.sh: Make it explicit for users to change case name run_e3sm: case_group argument activated for create_newcase when valid run_e3sm script: Replace default case name and case group placeholders Add support for northamericax4v1pg2_EC30to60E2r2 resolution Updates seaice BGC namelist defaults to match Registry defaults. Summit perf archive: set location to cli115 for all Corrected possible division by zero in ice bgc Enable performance archiving for all projects on Summit added '-O1 -hfp0' flags for crayclang to reduce NaN-related errors ...
This PR improves the MPAS Stream Manager by introducing an optional argument to differentiate between streams of direction INPUT and direction INPUT_OUTPUT. Previously, the mpas_stream_mgr_read() routine ignored the difference
between streams of direction INPUT and direction INPUT_OUTPUT (i.e. restart streams). However, there are situation where it would be desirable to read only truly direction INPUT streams. One example is at the initial time of a coldstart run - one would typically want to read any input streams without reading the restart stream (which does not exist yet). This PR adds an optional argument to force mpas_stream_mgr_read to ignore INPUT_OUTPUT streams and only read truly INPUT streams. Its default value maintains the previous behavior. A second commit modifies the MALI driver to make use of this new capability to improve and simplify the input stream handling at the initial time of a MALI simulation.
[BFB]