-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed confusing warning error messages from forcing #5498
Removed confusing warning error messages from forcing #5498
Conversation
Added framework function to check if pool exists In forcing framework check for input pool before accessing to avoid confusing error messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by inspection. I'm surprised this didn't already exist, but looking around it was clear there isn't already something similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a reasonable change to me. Approved by inspection.
passes:
merged to next |
merged to master |
This merge updates the E3SM-Project submodule from [c9201a4](https://github.com/E3SM-Project/E3SM/tree/c9201a4f44540bb74cb3650e32bcbe27fb762ab1) to [b4d5b10600](https://github.com/E3SM-Project/E3SM/tree/b4d5b10600). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#5254 - [ ] (fwk) E3SM-Project/E3SM#5490 - [ ] (ocn) E3SM-Project/E3SM#5541 - [ ] (fwk) E3SM-Project/E3SM#5498 - [ ] (ocn) E3SM-Project/E3SM#5564 - [ ] (ocn) E3SM-Project/E3SM#5553 - [ ] (ocn) E3SM-Project/E3SM#5519
Added framework function to check if pool exists
In forcing framework check for input pool before accessing to avoid confusing error messages
Fixes #5497
[BFB]