Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed confusing warning error messages from forcing #5498

Conversation

akturner
Copy link
Contributor

@akturner akturner commented Mar 3, 2023

Added framework function to check if pool exists
In forcing framework check for input pool before accessing to avoid confusing error messages

Fixes #5497

[BFB]

Added framework function to check if pool exists
In forcing framework check for input pool before accessing to avoid confusing error messages
Copy link
Contributor

@matthewhoffman matthewhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by inspection. I'm surprised this didn't already exist, but looking around it was clear there isn't already something similar.

@xylar xylar added the BFB PR leaves answers BFB label Mar 14, 2023
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable change to me. Approved by inspection.

jonbob added a commit that referenced this pull request Mar 21, 2023
…xt (PR #5498)

Removed confusing warning error messages from forcing

Added framework function to check if pool exists. Then in forcing
framework check for input pool before accessing to avoid confusing
error messages

Fixes #5497

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Mar 21, 2023

passes:

  • ERS.ne11_oQU240.WCYCL1850NS.chrysalis_intel
  • SMS_D_Ld3.T62_oQU120.CMPASO-IAF.chrysalis_intel

merged to next

@jonbob jonbob merged commit 68760cd into E3SM-Project:master Mar 22, 2023
@jonbob
Copy link
Contributor

jonbob commented Mar 22, 2023

merged to master

xylar added a commit to xylar/compass that referenced this pull request Apr 2, 2023
This merge updates the E3SM-Project submodule from [c9201a4](https://github.com/E3SM-Project/E3SM/tree/c9201a4f44540bb74cb3650e32bcbe27fb762ab1) to [b4d5b10600](https://github.com/E3SM-Project/E3SM/tree/b4d5b10600).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/E3SM#5254
- [ ]  (fwk) E3SM-Project/E3SM#5490
- [ ]  (ocn) E3SM-Project/E3SM#5541
- [ ]  (fwk) E3SM-Project/E3SM#5498
- [ ]  (ocn) E3SM-Project/E3SM#5564
- [ ]  (ocn) E3SM-Project/E3SM#5553
- [ ]  (ocn) E3SM-Project/E3SM#5519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPAS forcing system produces confusing warning/error messages
5 participants