Accumulate data land-ice mass fluxes #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this merge, we were only accumulating this flux in prognostic flux mode. With this merge, we accumulate the mass flux in data mode as well, as this term is needed in the total mass budget of the model. To facilitate this and reduce issues related to initialization vs. forward time stepping, this accumulation step has been broken into its own subroutine, ocn_surface_land_ice_fluxes_accumulate_fluxes. This subroutine is called when time-stepping the model but not at initialization (since we do not want to accumulate any fluxes at that time).
|
@jonbob, this is somewhere in the gray area between clean-up and a bug fix, but let's call it a bug fix. I expect it to be bit-for-bit except for runs in DISMF mode, and only with those runs if the |
2 tasks
mark-petersen
approved these changes
Sep 13, 2023
|
@darincomeau, can you take a look at this when you have time? |
|
@darincomeau please review. |
darincomeau
approved these changes
Sep 21, 2023
jonbob
added a commit
that referenced
this pull request
Sep 25, 2023
…next (PR #5910) Accumulate data land-ice mass fluxes Before this merge, we were only accumulating this flux in prognostic flux mode. With this merge, we accumulate the mass flux in data mode as well, as this term is needed in the total mass budget of the model. To facilitate this and reduce issues related to initialization vs. forward time stepping, this accumulation step has been broken into its own subroutine, ocn_surface_land_ice_fluxes_accumulate_fluxes(). This subroutine is called when time-stepping the model but not at initialization (since we do not want to accumulate any fluxes at that time). Fixes #5911 [BFB]
|
passes:
merged to next |
|
merged to master |
|
@jonbob Thanks so much! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this merge, we were only accumulating this flux in prognostic flux mode. With this merge, we accumulate the mass flux in data mode as well, as this term is needed in the total mass budget of the model.
To facilitate this and reduce issues related to initialization vs. forward time stepping, this accumulation step has been broken into its own subroutine,
ocn_surface_land_ice_fluxes_accumulate_fluxes(). This subroutine is called when time-stepping the model but not at initialization (since we do not want to accumulate any fluxes at that time).Fixes #5911