Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up remaining cmake deps and unused items #5990

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

jgfouca
Copy link
Member

@jgfouca jgfouca commented Oct 12, 2023

Changes:

  • Remove hdf5 stuff from the macros. FindNETCDF should take care of this stuff
  • Remove ESMF stuff that we don't use
  • Clean up some MPI stuff that was unused or had no effect on the build
  • gptl is now being handled properly in the new style

With this PR, I think all of our main dependencies are in a good enough state as far as cmake is concerned.

…cleanup

* origin/master: (325 commits)
  Set mappy to use generic blas
  blas/lapack settings should not depend on mpilib
  Refactor blas and lapack stuff a bit more
  revert fix for gravity wave convective heating
  Add back in kokkos options
  Revert to master version of gnugpu_pm-gpu.cmake
  add Kokkos_ENABLE_OPENMP=Off for gnugpu on pm-gpu
  add Kokkos_ENABLE_OPENMP=Off for gnugpu on Frontier
  add Kokkos_ENABLE_OPENMP=Off for Summit
  remove configure support for MMF m2005 microphysics
  configure clean up and remove samomp support
  add new lines
  re-enable CRM variance and momentum transport for MMF1
  add new line at end of pam_debug
  update default PAM time step
  update PAM submodule
  disable kokkos finalize in PAM driver
  add hyperdiffusion to PAM and refactor PAM driver
  update pam_statistics
  refactor pam_output
  ...
@jgfouca jgfouca added BFB PR leaves answers BFB CMake build system labels Oct 12, 2023
@jgfouca jgfouca requested review from bartgol and dqwu October 12, 2023 17:41
@jgfouca jgfouca self-assigned this Oct 12, 2023
@jgfouca jgfouca mentioned this pull request Oct 11, 2023
49 tasks
@github-actions
Copy link

PR Preview Action v1.4.4
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-5990/
on branch gh-pages at 2023-10-12 17:42 UTC

Copy link
Contributor

@bartgol bartgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

jgfouca added a commit that referenced this pull request Oct 12, 2023
Changes:
* Remove hdf5 stuff from the macros. FindNETCDF should take care of this stuff
* Remove ESMF stuff that we don't use
* Clean up some MPI stuff that was unused or had no effect on the build
* gptl is now being handled properly in the new style

With this PR, I think all of our main dependencies are in a good
enough state as far as cmake is concerned.

[BFB]

* jgfouca/more_cmake_cleanup:
  Clean up remaining cmake deps
@jgfouca jgfouca merged commit 6817fd9 into master Oct 18, 2023
2 checks passed
@jgfouca jgfouca deleted the jgfouca/more_cmake_cleanup branch October 18, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB CMake build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants