-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CMake variables/names in our cmake macros #6014
Merged
Merged
Changes from 4 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
33b76e7
Theta doesn't need to manually set netcdf slibs
jgfouca 08b9bf6
Restructure intel_anvil macro to be more parseable
jgfouca 3134589
Make nag.cmake more parseable
jgfouca c0a92a2
Not sure we keep this
jgfouca ffb4480
Make pgi_ascent more parseable
jgfouca 52d0a52
Clean up CXX_LINKER stuff a bit
jgfouca 86333ee
Remove FC_AUTO_R8 from macros, it wasn't being used for anything
jgfouca 0fd792d
The SUPPORTS_CXX concept was adding no value
jgfouca 7695869
Add macro converter script
jgfouca cb4eb27
Better handling of cuda/hip flags
jgfouca 2fb7b18
Remove instances of ZLIB and SLIB PATH in macros
jgfouca 0e4e417
Add post_process step to macros to set final compilers
jgfouca fce4c7e
Clean up crayclang-scream-gpu a bit
jgfouca 78c1438
Merge CXX_LDFLAGS and CXX_LIBS; they are the same concept
jgfouca 0d902f5
Various cleans and fixes
jgfouca d1bbc7a
mct and mpi-serial need to look at CONFIG_ARGS from macros
jgfouca f4ee575
Bit more cleanup
jgfouca 7b28bad
Clean up HAS_F2008_CONTIGUOUS a bit
jgfouca 4cf71b7
Remove CXX_LINKER and CXX_LIBS
jgfouca 809525f
Stop micromanaging linker
jgfouca dfe1ade
First attempt to convert macros
jgfouca 1107d6b
Progress
jgfouca f76c5f8
Progress
jgfouca 7f9228a
Merge remote-tracking branch 'origin/master' into jgfouca/cmake_names…
jgfouca 7f5b078
Clean up some logic in build_model
jgfouca f2e04d4
Updating compare-flags to look at logs
jgfouca 18b455d
Fixes for using cmake vars
jgfouca 5330bd8
Better way to handle free/fixed fortran
jgfouca 198c7b8
Fixes for free/fixed and macro exp
jgfouca cdfebee
Clean up deoptimization a bit
jgfouca 9e6f04e
Remove FFLAGS_NOOPT concept
jgfouca 81d80e0
Cleanup kokkos sharedlib build wrapper
jgfouca 3af01f9
Revert "Not sure we keep this"
jgfouca a4c868a
More fixes to buildlib.kokkos and post_process.cmake needs to not blo…
jgfouca 73b395a
More fixes to sharedlibs
jgfouca 253dd26
We haven't used Makefiles to build cosp in years
jgfouca 94d6a36
Remove last uses of e3sm_remove_flag in Depends files
jgfouca 8771928
Turn on verbose makefiles for gptl
jgfouca 4d44ecd
gptl build fixes
jgfouca 19bd6d5
Allow fortran linking if we have to
jgfouca 435ce72
Merge remote-tracking branch 'origin/master' into jgfouca/cmake_names…
jgfouca fe1b459
Fixes for pgi
jgfouca bc35c3b
Fixes for fortran linking
jgfouca 6def04a
Merge remote-tracking branch 'origin/master' into jgfouca/cmake_names…
jgfouca 42c41fc
Merge remote-tracking branch 'origin/master' into jgfouca/cmake_names…
jgfouca 10f1bac
Update upstream macros
jgfouca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This is a CMake supported/handled variable, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I think CMake can probably handle this automatically but I'm not 100% on that so I kept it.