-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tidal boundary conditions to split-explicit time integrator #6049
Add tidal boundary conditions to split-explicit time integrator #6049
Conversation
TestingThis PR is BFB with #6047 across the compass PR test suite on chrysalis with intel, openmpi. The linear tidal forcing feature is tested with a new configuration of the |
notes: ready but low priority |
@cbegeman -- I asked @mark-petersen to review, but please add anyone else who makes sense as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiled with intel on chrysalis and ran nightly test suite. Compares bfb against master branch point, as expected.
This all looks reasonable. The new code is protected by flags when the boundary tidal forcing is off. Approving based on @cbegeman's tests above, where the drying slope
test has boundary forcing. Very nice!
Add tidal boundary conditions to split-explicit time integrator This PR adds the option to have a tidal boundary condition with the split-explicit time integrator. Formerly, only tidal boundary conditions were supported with RK4. This PR also includes options for a linearly-varying tidal boundary condition to match a test case from O'Dea et al. 2021 used for validation. [BFB] used by standalone mpaso only
passes:
merged to next |
@mark-petersen Thank you for your review and testing and @jonbob thanks for your testing! |
merged to master |
This PR adds the option to have a tidal boundary condition with the split-explicit time integrator. Formerly, only tidal boundary conditions were supported with RK4. The changes to the ssh and layerThickness terms are described in https://www.overleaf.com/read/htysppyxksyh#6b2d8f.
This PR also includes options for a linearly-varying tidal boundary condition to match a test case from O'Dea et al. 2021 used for validation.
This work depends on #6047 in that the test cases used for verification of the forcing will fail without the use of upwinded advection and that fix.
[BFB] when feature is turned off
This feature is only available in MPAS-Ocean standalone configurations.