Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new RRSwISC6to18E3r1 ocean and sea-ice mesh #6060

Closed
wants to merge 6 commits into from

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Nov 8, 2023

Long name: RRSwISC6to18L80E3SMv3r1

This RRS (Rossby-radius scaled) mesh has:

  • 6 km resolution near the poles
  • 18 km resolution at the equator

This is a proposed E3SM v3 (E3) high resolution (near-eddy-resolving) mesh. This is revision 1 (r1) of the mesh, since we caught and fixed the issues with Greenland topography (seen in earlier revisions of EC and Icos meshes) before any substantial testing was performed.

The mesh was created using compass, specifically this PR:
MPAS-Dev/compass#668
A compass tag will be created for the mesh as soon as the PR is merged.

The mesh and forthcoming simulation results will be reviewed here:
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/3894149135/Review+RRSwISC6to18E3r1

G- and B-case simulations will begin shortly and analysis will be posted here and on the review page as soon as it is available.

@xylar
Copy link
Contributor Author

xylar commented Nov 8, 2023

Moved from E3SM-Ocean-Discussion#59, which has a small amount of relevant discussion.

Copy link
Member

@rljacob rljacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of map names need to change to follow our new convenction. Anything with "pg2" and "mono" is really "traave". The "bilin" should be "trbilin".

@@ -3265,6 +3307,14 @@
<map name="OCN2ATM_SMAPNAME">cpl/gridmaps/ECwISC30to60E3r2/map_ECwISC30to60E3r2_to_ne30pg2_traave.20231018.nc</map>
</gridmap>

<gridmap atm_grid="ne30np4.pg2" ocn_grid="RRSwISC6to18E3r1">
<map name="ATM2OCN_FMAPNAME">cpl/gridmaps/ne30pg2/map_ne30pg2_to_RRSwISC6to18E3r1_mono.230914.nc</map>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be renamed to "traave" instead of "mono".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rljacob -- I'll regenerate the mapping files to match the new algorithms and naming convention

@mt5555
Copy link
Contributor

mt5555 commented Nov 8, 2023

the atm2ocn flux map might have the blocky grid imprinting issue in coupled simulations (for the low-res ne30pg2 atmosphere coupled to this new ocean grid)
(i.e. https://acme-climate.atlassian.net/wiki/spaces/ECG/pages/2350776353/2-17-2021+Cryosphere+Simulation+Campaign )

if this is used for coupled simulations we may want to consider upgrading the atm2ocn map to a "nonlinear" flux map:
https://acme-climate.atlassian.net/wiki/spaces/COM/pages/3771301899/Coupler+High-order+property-preserving+maps

@xylar
Copy link
Contributor Author

xylar commented Nov 8, 2023

@jonbob, I think these comments are things you may be able to best address. Feel free to push to this branch.

Copy link
Contributor

@proteanplanet proteanplanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed bathymetry, narrow passages, and ice shelf cavities both numerically and visually. Summary plots are provided below for packaging with this PR and later referral. Approved for the magnificent quality of the mesh.

image

image

image

image

image

image

image

image

MPAS_OceanIce_ECwISC30to60E3r2_RRSwISC6to18E3r1_zoom_bathymetry_31

MPAS_OceanIce_ECwISC30to60E3r2_RRSwISC6to18E3r1_zoom_bathymetry_32

MPAS_OceanIce_ECwISC30to60E3r2_RRSwISC6to18E3r1_zoom_bathymetry_33

MPAS_OceanIce_ECwISC30to60E3r2_RRSwISC6to18E3r1_zoom_bathymetry_34

MPAS_OceanIce_ECwISC30to60E3r2_RRSwISC6to18E3r1_zoom_bathymetry_35

MPAS_OceanIce_ECwISC30to60E3r2_RRSwISC6to18E3r1_zoom_bathymetry_36

MPAS_OceanIce_ECwISC30to60E3r2_RRSwISC6to18E3r1_zoom_bathymetry_45

MPAS_OceanIce_ECwISC30to60E3r2_RRSwISC6to18E3r1_zoom_bathymetry_46

MPAS_OceanIce_ECwISC30to60E3r2_RRSwISC6to18E3r1_zoom_bathymetry_47

@xylar
Copy link
Contributor Author

xylar commented Nov 8, 2023

@proteanplanet, I appreciate you posting these plots! I'd request that you hold off on approving the mesh, though, until we've done some forward simulations (preferably fully coupled) so we can see what the behavior is like. I have put this up so that reviewers can approve this PR and the associated columns in the confluence document together. I didn't have a chance to explain this to you all, I'm afraid. I was just asked to make this mesh the next priority earlier today.

@xylar
Copy link
Contributor Author

xylar commented Nov 20, 2023

I'm putting this in draft mode because I just discovered a bug in landIceMask (which affects the initial condition as well as several mapping files) over the weekend.

MPAS-Dev/compass#732

@xylar
Copy link
Contributor Author

xylar commented Dec 7, 2023

Closing this because of the landIceMask bug. We will generate a new version with the bug fixed in the new year.

@xylar xylar closed this Dec 7, 2023
@xylar xylar deleted the mesh/add-rrswisc6to18e3r1 branch December 12, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-ocean mpas-seaice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants