Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pgi compiler flags #6103

Merged
merged 8 commits into from
Dec 18, 2023
Merged

Update pgi compiler flags #6103

merged 8 commits into from
Dec 18, 2023

Conversation

amametjanov
Copy link
Member

@amametjanov amametjanov commented Dec 6, 2023 •
edited
Loading

Update pgi compiler flags:

  • add missing -lstdc++ to pgi and nvidia linker flags
  • fix mpas-ocean openacc nightly
  • enable mpas openacc on nvidiagpu + pm-gpu
  • fix other miscellaneous errors.

[BFB]

@amametjanov amametjanov added Machine Files BFB PR leaves answers BFB PGI labels Dec 6, 2023
@amametjanov amametjanov self-assigned this Dec 6, 2023
amametjanov added a commit that referenced this pull request Dec 6, 2023
@amametjanov
Merge branch 'azamat/pgi/update-cmake-link-flags' into next (PR #6103)
d329e60 
Add missing -lstdc++ to pgi linker flags.

[BFB]
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

PR Preview Action v1.4.4
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6103/
on branch gh-pages at 2023-12-11 05:15 UTC

@rljacob
Copy link
Member

rljacob commented Dec 6, 2023

Which machine did you test this pgi change on?

@amametjanov
Copy link
Member Author

I checked on Ascent, but I suspect -lstdc++ will also be needed for machines with nvidia compilers.

amametjanov added a commit that referenced this pull request Dec 8, 2023
@amametjanov
Merge branch 'azamat/pgi/update-cmake-link-flags' into next (PR #6103)
7a74ee5 
Re-merge to next to bring new commits.
amametjanov added a commit that referenced this pull request Dec 8, 2023
@amametjanov
Merge branch 'azamat/pgi/update-cmake-link-flags' into next (PR #6103)
b92c11c 
Re-merge to next to fix CMPASO case for pgigpu
@amametjanov amametjanov changed the title Add missing -lstdc++ to pgi linker flags Update pgi compiler flags Dec 9, 2023
amametjanov added a commit that referenced this pull request Dec 9, 2023
@amametjanov
Merge branch 'azamat/pgi/update-cmake-link-flags' into next (PR #6103)
bd695b5 
Re-merge to next to enable mpas openacc on nvidiagpu
@amametjanov
Add more PEs on Ascent
f7a3eec 
To get these to PASS:
- ERS_D.ne4_oQU240.F2010.ascent_gnu.eam-hommexx: 1->2 nodes
- SMS_Ld20_D.f45_f45.IELMFATES.ascent_gnu.elm-fates_rd: 8->84 tasks
amametjanov added a commit that referenced this pull request Dec 11, 2023
@amametjanov
Merge branch 'azamat/pgi/update-cmake-link-flags' into next (PR #6103)
e289028 
Re-merge to next: add more PEs
@amametjanov amametjanov requested a review from rljacob December 11, 2023 05:30
@amametjanov
Copy link
Member Author

amametjanov commented Dec 11, 2023 •
edited
Loading

This fixes several tests on Ascent:

In miscellaneous:

  • fixes build error in SMS_Ln3.ne4pg2_ne4pg2.F2010-MMF2.pm-cpu_intel
  • enables e3sm_gpuacc on pm-gpu

@amametjanov amametjanov merged commit 524b754 into master Dec 18, 2023
3 checks passed
@amametjanov amametjanov deleted the azamat/pgi/update-cmake-link-flags branch December 18, 2023 18:01
@hyungyukang hyungyukang mentioned this pull request Dec 23, 2023
Merged
@xylar xylar mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rljacob rljacob rljacob approved these changes

Assignees

@amametjanov amametjanov

Labels
BFB PR leaves answers BFB Machine Files PGI Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amametjanov @rljacob