Fix for bad leaf C:N ratios during transient land simulations #6370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dmricciuto
changed the title
|
Is this non-BFB just for 20TR cases? |
bishtgautam
reviewed
May 5, 2024
Comment on lines
186
to
196
| !if (tot_leaf == 0._r8 .or. ignore_current_state) then | ||
| if (veg_vp%evergreen(pft_type) == 1._r8) then | ||
| pleaf = 1._r8 | ||
| else | ||
| pstorage = 1._r8 | ||
| end if | ||
| else | ||
| pleaf = leaf /tot_leaf | ||
| pstorage = leaf_storage/tot_leaf | ||
| pxfer = leaf_xfer /tot_leaf | ||
| end if | ||
| !else | ||
| ! pleaf = leaf /tot_leaf | ||
| ! pstorage = leaf_storage/tot_leaf | ||
| ! pxfer = leaf_xfer /tot_leaf | ||
| !end if |
There was a problem hiding this comment.
let's delete these commented-out lines and reindent the remaining lines.
There was a problem hiding this comment.
@dmricciuto lease take care of above comment.
|
Discussion: might be needed for transient runs. should be BFB for 1850 spinup. Transient runs have started so have gotten lucky so far. |
|
Would definitely change answers for already started v3 20TR runs so probably can't be in v3.0 code. |
bpbond
approved these changes
Sep 17, 2024
|
@bishtgautam this is the oldest 3.1beta PR. Would it be the first land one to go in? |
|
@rljacob, The order in which this non-BFB is merged into the master does not matter. |
|
go ahead and start merging this |
dmricciuto
force-pushed
the
dmricciuto/elm/seed_bugfix
branch
from
df11bbe to
442e068
Compare
|
@dmricciuto so this wasn't ready? |
bishtgautam
added a commit
that referenced
this pull request
Oct 22, 2024
Fix for seed initialization that caused C:N an C:P ratios to diverge for some grid cells in transient simulations. Fixes #6368 [non-BFB]
bishtgautam
added a commit
that referenced
this pull request
Oct 24, 2024
Fix for seed initialization that caused C:N an C:P ratios to diverge for some grid cells in transient simulations. Fixes #6368 [non-BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for seed initialization that caused C:N an C:P ratios to diverge for some grid cells in transient simulations.
Fixes #6368
[non-BFB]