Fixes gotm interface for vertical mixing #6509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if GOTM is enabled surface friction velocity is not calculated at present. This fixes that issue Addresses #6507
|
This only affects simulations where |
|
@qingli411 can you also have a look at this change? |
|
|
This looks good to me. |
|
@mark-petersen please review. |
mark-petersen
approved these changes
Aug 19, 2024
jonbob
approved these changes
Aug 20, 2024
jonbob
added a commit
that referenced
this pull request
Aug 20, 2024
Fixes gotm interface for vertical mixing If GOTM is enabled surface friction velocity is not calculated at present. This fixes that issue by allowing KPP_input_fields to be calculated for cvmix and gotm Fixes #6507 [BFB]
|
Passes:
merged to next |
|
merged to master |
xylar
added a commit
to xylar/compass
that referenced
this pull request
Oct 26, 2024
This merge updates the E3SM-Project submodule from [727ad81](https://github.com/E3SM-Project/E3SM/tree/727ad81) to [1442143](https://github.com/E3SM-Project/E3SM/tree/1442143). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#6509 - [ ] (ocn) E3SM-Project/E3SM#6508 - [ ] (fwk) E3SM-Project/E3SM#6575 - [ ] (ocn) E3SM-Project/E3SM#6590 - [ ] (fwk) E3SM-Project/E3SM#6643 - [ ] (ocn) E3SM-Project/E3SM#6656 - [ ] (ocn) E3SM-Project/E3SM#6672 - [ ] (ocn) E3SM-Project/E3SM#6659 - [ ] (ocn) E3SM-Project/E3SM#6497 - [ ] (ocn) E3SM-Project/E3SM#6485 - [ ] (ocn) E3SM-Project/E3SM#6566
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if GOTM is enabled surface friction velocity is not calculated at present. This fixes that issue by allowing KPP_input_fields to be calculated for cvmix and gotm
Fixes #6507
[BFB]