Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CRYO compsets to v3 ELM settings #6625

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

darincomeau
Copy link
Member

@darincomeau darincomeau commented Sep 19, 2024

Updates the ELM settings in the following compsets to the v3 settings in #6108.

CRYO1850
CRYO1850-DISMF
CRYO1850-4xCO2
CRYO1950
CRYO1950-DISMF
CRYO20TR
CRYOSSP370
CRYOSSP585

Adds CRYO1850-1pctCO2 and CRYOSSP245 compsets matching the WCYCL counterparts.

[BFB]
[non-BFB] only for CRYO* compsets.

@darincomeau
Copy link
Member Author

darincomeau commented Sep 19, 2024

Passes

SMS.ne30pg2_r05_IcoswISC30E3r5.CRYO1850.chrysalis_intel
SMS.ne30pg2_r05_IcoswISC30E3r5.CRYO1850-4xCO2.chrysalis_intel
SMS.ne30pg2_r05_IcoswISC30E3r5.CRYO1850-1pctCO2.chrysalis_intel
SMS.ne30pg2_r05_IcoswISC30E3r5.CRYO20TR.chrysalis_intel (after doing ./xmlchange RUN_STARTDATE="1850-01-01")
SMS.ne30pg2_r05_IcoswISC30E3r5.CRYOSSP245.chrysalis_intel
ERS.ne30pg2_r05_IcoswISC30E3r5.CRYO1850-DISMF.chrysalis_intel

I've left the following compsets unchanged since there are no plans to use them for v3. However it might be best to change these as well for consistency.
CRYO1950
CRYO1950-DISMF
CRYOSSP370
CRYOSSP585

Updated to include these.

@darincomeau darincomeau changed the title Updating CRYO1850* compsets to v3 ELM settings Updating CRYO compsets to v3 ELM settings Sep 19, 2024
@darincomeau
Copy link
Member Author

Flagging @stephenprice and @proteanplanet as Polar leads (I don't think you need to review but you're welcome to).

@rljacob
Copy link
Member

rljacob commented Sep 19, 2024

For those other compsets (CRYO1950, etc.), if you're not going to use them, just remove them.

@stephenprice
Copy link
Contributor

Looks good to me Darin. Thanks.

@proteanplanet
Copy link
Contributor

@darincomeau Thanks for doing this. I wonder if we still need CRYO1950, CRYO1950-DISMF, and CRYOSSP370 up our sleeve in case we want to run a comparison, however short, with V2?

@stephenprice
Copy link
Contributor

I think we should keep the 1950 support for a bit yet.

@darincomeau
Copy link
Member Author

I agree Andrew, Steve. I've made the change for all CRYO compsets.

Additionally tested and passes:

SMS.ne30pg2_IcoswISC30E3r5.CRYO1950.chrysalis_intel
SMS.ne30pg2_IcoswISC30E3r5.CRYO1950-DISMF.chrysalis_intel
SMS.ne30pg2_r05_IcoswISC30E3r5.CRYOSSP370.chrysalis_intel
SMS.ne30pg2_r05_IcoswISC30E3r5.CRYOSSP585.chrysalis_intel

@rljacob
Copy link
Member

rljacob commented Sep 20, 2024

@wlin7 please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants