Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new JRA forcing through year 2023 #6628

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

jonbob
Copy link
Contributor

@jonbob jonbob commented Sep 19, 2024

Adds new datm and drof settings to support JRA forcing through 2023, as well as a new G-case compset that uses the forcing. It is distinguished from the typical JRA-1p5 in the compset aliases, GMPAS-JRA1p5-2023 and GMPAS-JRA1p5, for backwards compatibility.

[BFB]

Copy link

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6628/
on branch gh-pages at 2024-09-19 16:36 UTC

@jonbob
Copy link
Contributor Author

jonbob commented Sep 19, 2024

All new forcing files are available on the inputdata repo

Copy link
Member

@darincomeau darincomeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes

SMS.TL319_IcoswISC30E3r5.GMPAS-JRA1p5-2023.chrysalis_intel

I checked the data.streams and drof.streams and see the end date as 2023 as expected.

@alicebarthel
Copy link
Contributor

Sorry, I just saw the PR yesterday. It looks good visually.
I successfully ran 1month on Chrysalis. Like Darin, the logs and streams look good (with 2023 as end date).
Testing on pm now, the datm files are being downloaded with WGET, I'll update when it runs successfully.
@jonbob Did you want us to run other tests (e.g. actually running to 2023) or will that be done at another stage?

@jonbob
Copy link
Contributor Author

jonbob commented Oct 2, 2024

Thanks @alicebarthel. Luke had previously made a run through 2023 with these files, so I wasn't going to test it beyond the sanity checks you and @darincomeau and I made

Copy link
Contributor

@alicebarthel alicebarthel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passes
SMS.TL319_IcoswISC30E3r5.GMPAS-JRA1p5-2023.pm-cpu_intel
SMS.TL319_oRRS18to6v3.GMPAS-JRA1p5-2023.pm-cpu_intel
Successfully ran S_1x1_nmonth on chrysalis and the files look good.

jonbob added a commit that referenced this pull request Oct 7, 2024
Add support for new JRA forcing through year 2023

Adds new datm and drof settings to support JRA forcing through 2023, as
well as a new G-case compset that uses the forcing. It is distinguished
from the typical JRA-1p5 in the compset aliases, GMPAS-JRA1p5-2023 and
GMPAS-JRA1p5, for backwards compatibility.

[BFB]
@jonbob
Copy link
Contributor Author

jonbob commented Oct 7, 2024

Passed:

  • SMS_D_Ld1.TL319_IcoswISC30E3r5.GMPAS-JRA1p5-DIB-PISMF.chrysalis_intel.mpaso-jra_1958
  • SMS_D_Ld1.TL319_IcoswISC30E3r5.DTESTM-JRA1p5.chrysalis_intel.mpassi-jra_1958

merged to next

@jonbob jonbob merged commit 5130bd1 into master Oct 8, 2024
5 checks passed
@jonbob jonbob deleted the jonbob/datm/add-jra-1p5-2023 branch October 8, 2024 15:38
@jonbob
Copy link
Contributor Author

jonbob commented Oct 8, 2024

merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants